1799515 - Mach browsertime fails on Windows

Status: RESOLVED FIXED

(Core :: Performance Engineering, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Error running mach:

    ['browsertime', '--setup', '--clobber']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file browsertime| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Cannot find an extracted directory: C:/Users/emilio/.mozbuild/browsertime\ffmpeg-4.4.1-full_build-win

  File "C:\moz\mozilla-unified\tools\browsertime\mach_commands.py", line 672, in browsertime
    return setup_browsertime(
  File "C:\moz\mozilla-unified\tools\browsertime\mach_commands.py", line 284, in setup_browsertime
    setup_prerequisites(command_context)
  File "C:\moz\mozilla-unified\tools\browsertime\mach_commands.py", line 250, in setup_prerequisites
    raise Exception("Cannot find an extracted directory: %s" % path)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1799515 - Fix mach browsertime path for ffmpeg. r=sparky,#perftest-reviewers

With this browsertime works locally.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Well I spoke too fast:

18:29:19     INFO -  Looking in links: https://pypi.pub.build.mozilla.org/pub/
18:29:21     INFO -  Collecting scipy==1.7.3
18:29:21     INFO -    Downloading https://pypi.pub.build.mozilla.org/pub/scipy-1.7.3-cp39-cp39-win_amd64.whl (34.3 MB)
18:33:03     INFO -  ERROR: Exception:
18:33:03    ERROR -  Traceback (most recent call last):
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\cli\base_command.py", line 173, in _main
18:33:03     INFO -      status = self.run(options, args)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\cli\req_command.py", line 203, in wrapper
18:33:03     INFO -      return func(self, options, args)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\commands\install.py", line 315, in run
18:33:03     INFO -      requirement_set = resolver.resolve(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\resolver.py", line 94, in resolve
18:33:03     INFO -      result = self._result = resolver.resolve(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 472, in resolve
18:33:03     INFO -      state = resolution.resolve(requirements, max_rounds=max_rounds)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 341, in resolve
18:33:03     INFO -      self._add_to_criteria(self.state.criteria, r, parent=None)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 172, in _add_to_criteria
18:33:03     INFO -      if not criterion.candidates:
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_vendor\resolvelib\structs.py", line 151, in __bool__
18:33:03     INFO -      return bool(self._sequence)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 140, in __bool__
18:33:03     INFO -      return any(self)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 128, in <genexpr>
18:33:03     INFO -      return (c for c in iterator if id(c) not in self._incompatible_ids)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 32, in _iter_built
18:33:03     INFO -      candidate = func()
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\factory.py", line 204, in _make_candidate_from_link
18:33:03     INFO -      self._link_candidate_cache[link] = LinkCandidate(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 295, in __init__
18:33:03     INFO -      super().__init__(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 156, in __init__
18:33:03     INFO -      self.dist = self._prepare()
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 227, in _prepare
18:33:03     INFO -      dist = self._prepare_distribution()
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 305, in _prepare_distribution
18:33:03     INFO -      return self._factory.preparer.prepare_linked_requirement(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\operations\prepare.py", line 508, in prepare_linked_requirement
18:33:03     INFO -      return self._prepare_linked_requirement(req, parallel_builds)
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\operations\prepare.py", line 570, in _prepare_linked_requirement
18:33:03     INFO -      dist = _get_prepared_distribution(
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\operations\prepare.py", line 61, in _get_prepared_distribution
18:33:03     INFO -      return abstract_dist.get_pkg_resources_distribution()
18:33:03     INFO -    File "C:\moz\mozilla-unified\obj-x86_64-pc-mingw32\testing\raptor-venv\lib\site-packages\pip\_internal\distributions\wheel.py", line 26, in get_pkg_resources_distribution
18:33:03     INFO -      with ZipFile(self.req.local_file_path, allowZip64=True) as z:
18:33:03     INFO -    File "C:\mozilla-build\python3\lib\zipfile.py", line 1257, in __init__
18:33:03     INFO -      self._RealGetContents()
18:33:03     INFO -    File "C:\mozilla-build\python3\lib\zipfile.py", line 1324, in _RealGetContents
18:33:03     INFO -      raise BadZipFile("File is not a zip file")
18:33:03     INFO -  zipfile.BadZipFile: File is not a zip file

But that seems unrelated to this issue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0315e84bfae4
Fix mach browsertime path for ffmpeg. r=sparky,perftest-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0315e84bfae4