1799877 - Setting NotificationBox label should support Fluent

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Eemeli Aro [:eemeli]]

The changes made in bug 1646160 allow using an { l10n-id, l10n-args } object as the label of a notification in an appendNotification() call, but not in a notification's set label().

Including Fluent support in the latter would allow for less fragile modifications of localized notification labels, as noted by Dao here.

Comment 1

[Eemeli Aro [:eemeli]]

Attachment: Bug 1799877 - Allow using { l10n-id, l10n-args } object when setting notification label. r=mstriemer!,dao

This matches the existing behavior of NotificationBox.appendNotification().

Comment 2

[Eemeli Aro [:eemeli]]

For context, the need for this API was identified in this discussion on a patch for bug 1760029.

Mark, I requested the patch review from you as you'd reviewed the patch for bug 1646160, but would you be comfortable with this going forward with just Dão's r+?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca9d371d075
Allow using { l10n-id, l10n-args } object when setting notification label. r=dao,mstriemer

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5ca9d371d075