1799886 - Fix failing android page load recording task

Status: NEW

(Testing :: mozperftest, defect, P2)

Description

[Kash Shampur [:kshampur] ⌚EST]

android jobs for recording website page loads are failing in ci. e.g. recent Try

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=AfnnCgUvRPGR8KKqEQYprg.0&tier=1%2C2%2C3&revision=3a5d052f16c95dfaa43b6df13bf603a66dda26be

It always seems to fail after the first recording is completed. It seems the first one is always successful though (as you can see the artifacts for it and the screenshot looks correct)

partial snippet of failure:

[task 2022-11-08T23:12:11.540Z]  5:32.36 Running browsertime with this command /builds/worker/.mozbuild/browsertime/node_modules/browsertime/bin/browsertime.js -b firefox --skipHar --viewPort 1280x1024 --firefox.geckodriverPath /builds/task_166794834297728/fetches/geckodriver --resultDir /builds/task_166794834297728/artifacts/browsertime-results-1 --firefox.profileTemplate /tmp/tmp88nl9gd8.mozrunner --iterations 1 /builds/task_166794834297728/checkouts/gecko/testing/performance/perftest_record.js --firefox.preference mozperftest:true --firefox.preference network.proxy.type:1 --firefox.preference network.proxy.http:127.0.0.1 --firefox.preference network.proxy.http_port:50573 --firefox.preference network.proxy.ssl:127.0.0.1 --firefox.preference network.proxy.ssl_port:50573 --firefox.preference network.proxy.no_proxies_on:127.0.0.1 --browsertime.url https://www.allrecipes.com/ --browsertime.screenshot true --browsertime.testName allrecipes --browsertime.testType pageload --browsertime.login False --browsertime.dismiss_cookie_prompt click.byXpathAndWait::://*[@id='onetrust-reject-all-handler'] --android --firefox.android.package org.mozilla.geckoview_example --firefox.android.activity org.mozilla.geckoview_example.GeckoViewActivity
[task 2022-11-08T23:12:11.540Z]  5:32.36 /builds/task_166794834297728/fetches/node/bin/node /builds/worker/.mozbuild/browsertime/node_modules/browsertime/bin/browsertime.js -b firefox --skipHar --viewPort 1280x1024 --firefox.geckodriverPath /builds/task_166794834297728/fetches/geckodriver --resultDir /builds/task_166794834297728/artifacts/browsertime-results-1 --firefox.profileTemplate /tmp/tmp88nl9gd8.mozrunner --iterations 1 /builds/task_166794834297728/checkouts/gecko/testing/performance/perftest_record.js --firefox.preference mozperftest:true --firefox.preference network.proxy.type:1 --firefox.preference network.proxy.http:127.0.0.1 --firefox.preference network.proxy.http_port:50573 --firefox.preference network.proxy.ssl:127.0.0.1 --firefox.preference network.proxy.ssl_port:50573 --firefox.preference network.proxy.no_proxies_on:127.0.0.1 --browsertime.url https://www.allrecipes.com/ --browsertime.screenshot true --browsertime.testName allrecipes --browsertime.testType pageload --browsertime.login False --browsertime.dismiss_cookie_prompt click.byXpathAndWait::://*[@id='onetrust-reject-all-handler'] --android --firefox.android.package org.mozilla.geckoview_example --firefox.android.activity org.mozilla.geckoview_example.GeckoViewActivity
[task 2022-11-08T23:12:11.540Z]  5:35.81 Run tests on SM-A515F [R58R35CX8GZ] using Android version 11
[task 2022-11-08T23:12:11.540Z]  5:35.81 Running tests using Firefox - 1 iteration(s)
[task 2022-11-08T23:12:11.540Z]  5:51.48 {"url":"https://www.allrecipes.com/","screenshot":"true","testName":"allrecipes","testType":"pageload","login":"False","dismiss_cookie_prompt":"click.byXpathAndWait::://*[@id='onetrust-reject-all-handler']"}
[task 2022-11-08T23:12:11.540Z]  5:52.49 Testing url https://www.allrecipes.com/ iteration 1
[task 2022-11-08T23:12:11.540Z]  6:43.62 Searching for cookie prompt elements...
[task 2022-11-08T23:12:11.540Z]  6:43.62 click.byXpathAndWait //*[@id='onetrust-reject-all-handler']
[task 2022-11-08T23:12:11.540Z]  6:43.70 Element not found! The cookie prompt may have not appeared, please check the screenshots.
[task 2022-11-08T23:12:11.540Z]  6:44.61 Missing sharp dependency so you can only save images as png at viewport size
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949131526, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Terminating mozproxy", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949131526, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Mitmproxy stop!!", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949131527, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Stopping mitmproxy playback, killing process 334", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949132311, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Successfully killed the mitmproxy playback process", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949132311, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Record mode ON. Generating zip file ", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z] {"action": "log", "time": 1667949132326, "thread": "MainThread", "pid": 317, "source": "mozproxy", "component": "mozproxy", "message": "Generated new recording file at: /builds/task_166794834297728/artifacts/mitm7-android-gve-allrecipes.zip", "exc_info": false, "level": "INFO"}
[task 2022-11-08T23:12:18.142Z]  6:46.52 Dumping logcat into '/builds/task_166794834297728/fetches/../artifacts/logcat'
[task 2022-11-08T23:12:18.142Z] Traceback (most recent call last):
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/runner.py", line 280, in <module>
[task 2022-11-08T23:12:18.142Z]     sys.exit(main())
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/runner.py", line 276, in main
[task 2022-11-08T23:12:18.142Z]     run_tests(mach_cmd, args, user_args)
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/runner.py", line 168, in run_tests
[task 2022-11-08T23:12:18.142Z]     e.run(metadata)
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/environment.py", line 93, in run
[task 2022-11-08T23:12:18.142Z]     metadata = testlayer(syslayer(metadata))
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/layers.py", line 156, in __call__
[task 2022-11-08T23:12:18.142Z]     metadata = layer(metadata)
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/layers.py", line 68, in __call__
[task 2022-11-08T23:12:18.142Z]     metadata = self.run(metadata)
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/test/browsertime/runner.py", line 378, in run
[task 2022-11-08T23:12:18.142Z]     metadata = self._one_cycle(metadata, result_dir)
[task 2022-11-08T23:12:18.142Z]   File "/builds/task_166794834297728/checkouts/gecko/python/mozperftest/mozperftest/test/browsertime/runner.py", line 467, in _one_cycle
[task 2022-11-08T23:12:18.142Z]     raise NodeException(exit_code)
[task 2022-11-08T23:12:18.142Z] mozperftest.test.browsertime.runner.NodeException: 1

The current work around if you want a single, specific recording, is to hardcode the pageload_sites.json which is not ideal of course