1799888 - Add bookmark dialog from the Library History view is cut

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Marco Bonardo [:mak]]

The tip text under the fields is not wrapping and the dialog contents end up being wrapped.
Additional height of the dialog is "broken" (too much, doesn't adapt to content)

STR:

1. open the library window and go to history
2. right click on an history entry and pick Bookmark Page

Expected:
contents are not cut and the window is properly sized

Actual:
contents are cut, the window height is excessive

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1799888 - Fix old style Add bookmark dialog sizing. r=standard8

Make mozSubdialogReady properly wait for async initialization, remove no longer
necessary resize listener (since the dialog is not resizable anymore), and
simplify the mutation observer.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b7b76a931ca
Fix old style Add bookmark dialog sizing. r=jteow

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6b7b76a931ca

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 9302840 [details]
Bug 1799888 - Fix old style Add bookmark dialog sizing. r=standard8

Beta/Release Uplift Approval Request

• User impact if declined: The add bookmark dialog opened from History in the Library is cut, one of the buttons may be unreachable
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Go to History in the Library window, right click on a url and pick Add to Bookmarks
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): The highest risk is regressing other cases where the dialog may end up being cut, though I tested all the known cases and didn't see problems.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9302840 [details]
Bug 1799888 - Fix old style Add bookmark dialog sizing. r=standard8

Approved for 108.0b4

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a41b8ac672c6

Comment 7

[Anca Soncutean, Desktop QA]

Reproduced on Fx 108.0a1 (2022-11-09) on Windows 10.
Verified fixed with Fx 109.0a1 (2022-11-20) and Fx 108.0b4 on Windows 10, Ubuntu 22.04 and macOS 12.1.