1799913 - Remove parameters from crash signatures in bug summaries

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, task)

Description

[Geoff Brown [:gbrown]]

https://phabricator.services.mozilla.com/D161483 changes the crash signature reported in automated tests such that parameters are no longer included. Instead of

PROCESS-CRASH | gtest | application crashed [@ SpanTest_from_nullptr_constructor_Test::TestBody()]

now we'll report

PROCESS-CRASH | gtest | application crashed [@ SpanTest_from_nullptr_constructor_Test::TestBody]

We are concerned that will make it more difficult to match up new test crashes with existing bugs, so want to update bug summaries to match the new signature format.

For example, bug 1790704,

Intermittent browser/components/newtab/test/browser/browser_newtab_ping.js | application crashed [@ MOZ_Crash(char const*, int, char const*)]

becomes

Intermittent browser/components/newtab/test/browser/browser_newtab_ping.js | application crashed [@ MOZ_Crash]

@aryx suggested using something like https://github.com/mozilla-bteam/bmo/blob/5924eec6eeb1d59ff8e1db6f078b24f3871833ad/scripts/update-crash-signatures.pl

Comment 1

[David Lawrence [:dkl]]

Note to self:

                                # Strip parameters from signature
                                pmatch = re.search(r"(.*)\(.*\)", func)
                                if pmatch:
                                    func = pmatch.group(1)

Comment 2

[David Lawrence [:dkl]]

Just to be clear, we want the summaries update AND the text in the crash signature field, or just the summaries? For bug 1790704, the summary both contain [@ MOZ_Crash(char const*, int, char const*)].

Comment 3

[Geoff Brown [:gbrown]]

I was thinking just the summaries. Probably the crash signature field also is a good idea. Hopefully :aryx can say more definitively.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Both. Summary gets used by Treeherder for failure line matching, crash-stats uses the summary field.

Comment 5

[David Lawrence [:dkl]]

Given my current workload trying to get my H2 goals completed and the impending holiday schedule, is this something that can wait til the first of the year? How critical is this to be done now?

Comment 6

[Geoff Brown [:gbrown]]

It's not critical - pursue when you can.

Comment 7

[Geoff Brown [:gbrown]]

Hi :dkl. Will you be able to get back to this? While there is no hard completion date requirement, I think there is value in making this change; I don't want it to be forgotten.

Comment 8

[BMO Automation]

Attachment: [mozilla-bteam/bmo] Bug 1799913 - Remove parameters from crash signatures in bug summaries (#2019)

Comment 9

[David Lawrence [:dkl]]

Merged. Should be able to run the migration script today or tomorrow.
https://github.com/mozilla-bteam/bmo/commit/be996be30cd92c1ff52d963de4fd9f8e4407be52

Comment 10

[David Lawrence [:dkl]]

Script has been ran without issue. Please let me know if you see anything wrong or need any further changes.