1800126 - [Cleanup] Refactor OnboardingVideo in its own component

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

https://phabricator.services.mozilla.com/D161233 fix lands support of playing video inside about:welcome

Scope of this bug is to move OnboardingVideo and its related telemetry code as its own component instead of defining inside MultiStageAboutWelcome.jsx

Comment 1

[Negin]

Attachment: Bug 1800126 - [Cleanup] Refactor OnboardingVideo in its own component

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b0244ce90fb
[Cleanup] Refactor OnboardingVideo in its own component r=yozhang

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for causing newtab failures.

• backout: https://hg.mozilla.org/integration/autoland/rev/db471ed0ff11d067c3e0e14831a43341b9910972
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=6b0244ce90fb7a86f1cf6a80c82567e11af7ede8&selectedTaskRun=cUABisXmSYSBx0oqAKtLgw.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=397347449&repo=autoland&lineNumber=253

[task 2022-11-22T16:09:42.627Z] + npm install
[task 2022-11-22T16:09:43.395Z] npm WARN EBADENGINE Unsupported engine {
[task 2022-11-22T16:09:43.395Z] npm WARN EBADENGINE   package: 'activity-streams@1.14.3',
[task 2022-11-22T16:09:43.395Z] npm WARN EBADENGINE   required: {
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE     firefox: '>=45.0 <=*',
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE     '//': 'when changing node versions, also edit .nvmrc',
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE     node: '10.23.*',
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE     npm: '6.14.10'
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE   },
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE   current: { node: 'v16.17.1', npm: '8.15.0' }
[task 2022-11-22T16:09:43.396Z] npm WARN EBADENGINE }
[task 2022-11-22T16:09:52.737Z] 
[task 2022-11-22T16:09:52.737Z] added 766 packages, and audited 767 packages in 10s
[task 2022-11-22T16:09:52.738Z] 
[task 2022-11-22T16:09:52.738Z] 1 package is looking for funding
[task 2022-11-22T16:09:52.738Z]   run `npm fund` for details
[task 2022-11-22T16:09:52.758Z] 
[task 2022-11-22T16:09:52.758Z] 28 vulnerabilities (10 moderate, 14 high, 4 critical)
[task 2022-11-22T16:09:52.758Z] 
[task 2022-11-22T16:09:52.758Z] To address issues that do not require attention, run:
[task 2022-11-22T16:09:52.758Z]   npm audit fix
[task 2022-11-22T16:09:52.758Z] 
[task 2022-11-22T16:09:52.758Z] To address all issues possible (including breaking changes), run:
[task 2022-11-22T16:09:52.758Z]   npm audit fix --force
[task 2022-11-22T16:09:52.758Z] 
[task 2022-11-22T16:09:52.758Z] Some issues need review, and may require choosing
[task 2022-11-22T16:09:52.758Z] a different dependency.
[task 2022-11-22T16:09:52.758Z] 
[task 2022-11-22T16:09:52.758Z] Run `npm audit` for details.
[task 2022-11-22T16:09:52.781Z] + node bin/try-runner.js
[task 2022-11-22T16:09:52.817Z] TEST START | checkBundles
[task 2022-11-22T16:10:01.134Z] TEST-UNEXPECTED-FAIL checkBundles | About:welcome bundle out of date
[task 2022-11-22T16:10:01.136Z] { checkBundles: false }
[task 2022-11-22T16:10:01.136Z] CODE 1
[taskcluster 2022-11-22 16:10:01.529Z] === Task Finished ===
[taskcluster 2022-11-22 16:10:01.529Z] Unsuccessful task run with exit code: 1 completed in 278.052 seconds

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a1faa41f831
[Cleanup] Refactor OnboardingVideo in its own component r=yozhang

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7a1faa41f831