1800379 - text overlap in networking settings (regression in localized version of Firefox 107)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

Please see the attached screenshot for the network settings in Firefox 107 with German as language. The "Learn more" link and the "Settings…" button overlap. I guess other languages with longer translations are affected as well. It's not reproducible with English.

It's a regression in Firefox 107, Firefox 106.0.5 is not affected.

Comment 1

[Sören Hentzschel]

I cannot bisect further as to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b66bbbcc4467d09a1ef10302ee1a085a675966a8&tochange=93a9b1ba6411a636b3f34e72ecef52fe87daca81

@Emilio:

Changing:

#preferences-root {
  -moz-box-layout: flex;
}

… to

#preferences-root {
  -moz-box-layout: initial;
}

… "fixes" the overlap. Therefore and because of the regression range I guess it's a regression from bug 1790307.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Before the patch the behavior was messy, stuff just kept growing horizontally indefinitely, now it wraps correctly.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1800379 - Fix layout of network settings description with long text. r=Gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/132b8562cffc
Fix layout of network settings description with long text. r=mconley

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/132b8562cffc

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9303232 [details]
Bug 1800379 - Fix layout of network settings description with long text. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very targetted improvement.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Donal Meehan [:dmeehan]]

Please consider a release uplift request for this when confident

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9303232 [details]
Bug 1800379 - Fix layout of network settings description with long text. r=Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very targeted and rather simple patch
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Emil Ghitta, QA [:emilghitta]]

Reproduced this issue using Firefox 108.0a1 (BuildId:20221114085151) with a DE locale.

This issue is verified fixed using Firefox 109.0a1 (BuildId:20221116182402) with a DE locale on Windows 10 64bit, macOS 11 & Ubuntu 22.04

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9303232 [details]
Bug 1800379 - Fix layout of network settings description with long text. r=Gijs

Approved for 108.0b3

Comment 12

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b8e109fe26c9

Comment 13

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 108.0b3 (BuildId:20221117185908) on Windows 10 64bit, macOS 11 & Ubuntu 22.04

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9303232 [details]
Bug 1800379 - Fix layout of network settings description with long text. r=Gijs

Approved for 107.0.1

Comment 15

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-release/rev/94249054e777

Comment 16

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 107.0.1 (BuildId:20221128144904) on Windows 10 64bit, macOS 11 & Ubuntu 22.04