Closed Bug 1800462 Opened 1 year ago Closed 1 year ago

Build failure on Windows: "error: failed to run custom build command for `quote v1.0.21`" [and other crates]

Categories

(Firefox Build System :: Toolchains, defect)

defect

Tracking

(firefox-esr102 unaffected, firefox107 unaffected, firefox108 wontfix, firefox109 fixed)

RESOLVED FIXED
109 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 --- wontfix
firefox109 --- fixed

People

(Reporter: jfkthame, Assigned: glandium)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(4 files)

I'm currently unable to build mozilla-central on my Windows machine, where it was working fine until the end of last week.

A clobber build with no custom mozconfig fails with:

 1:38.46    Compiling quote v1.0.21
 1:38.72    Compiling unicode-ident v1.0.3
 1:38.87 In file included from UnifiedBindings16.cpp:327:
 1:38.87 In file included from C:/mozdev/mozilla-unified/obj-x86_64-pc-mingw32/dom/bindings/RTCPeerConnectionBinding.cpp:14:
 1:38.87 In file included from C:/mozdev/mozilla-unified/dom/media/webrtc/jsapi\RTCRtpReceiver.h:14:
 1:38.87 In file included from C:/mozdev/mozilla-unified/dom/media/webrtc\libwebrtcglue/MediaConduitInterface.h:14:
 1:38.87 In file included from C:/mozdev/mozilla-unified/dom/media/webrtc\jsapi/RTCStatsReport.h:10:
 1:38.87 In file included from C:/mozdev/mozilla-unified/third_party/libwebrtc\api/units/timestamp.h:21:
 1:38.87 In file included from C:/mozdev/mozilla-unified/third_party/libwebrtc\api/units/time_delta.h:22:
 1:38.87 In file included from C:/mozdev/mozilla-unified/third_party/libwebrtc\rtc_base/units/unit_base.h:20:
 1:38.87 In file included from C:/mozdev/mozilla-unified/third_party/libwebrtc\rtc_base/checks.h:57:
 1:38.87 C:/mozdev/mozilla-unified/third_party/libwebrtc/third_party/abseil-cpp\absl/meta/type_traits.h(293,36): warning: builtin __has_trivial_destructor is deprecated; use __is_trivially_destructible instead [-Wdeprecated-builtins]
 1:38.87     : std::integral_constant<bool, __has_trivial_destructor(T) &&
 1:38.87                                    ^
 1:38.88 C:/mozdev/mozilla-unified/third_party/libwebrtc/third_party/abseil-cpp\absl/meta/type_traits.h(342,36): warning: builtin __has_trivial_constructor is deprecated; use __is_trivially_constructible instead [-Wdeprecated-builtins]
 1:38.88     : std::integral_constant<bool, __has_trivial_constructor(T) &&
 1:38.88                                    ^
 1:38.88 C:/mozdev/mozilla-unified/third_party/libwebrtc/third_party/abseil-cpp\absl/meta/type_traits.h(486,17): warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
 1:38.88           bool, __has_trivial_assign(typename std::remove_reference<T>::type) &&
 1:38.88                 ^
 1:38.88 C:/mozdev/mozilla-unified/third_party/libwebrtc/third_party/abseil-cpp\absl/meta/type_traits.h(551,8): warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]
 1:38.88       (__has_trivial_copy(ExtentsRemoved) || !kIsCopyOrMoveConstructible) &&
 1:38.88        ^
 1:38.88 C:/mozdev/mozilla-unified/third_party/libwebrtc/third_party/abseil-cpp\absl/meta/type_traits.h(552,8): warning: builtin __has_trivial_assign is deprecated; use __is_trivially_assignable instead [-Wdeprecated-builtins]
 1:38.88       (__has_trivial_assign(ExtentsRemoved) || !kIsCopyOrMoveAssignable) &&
 1:38.88        ^
 1:39.23 error: failed to run custom build command for `quote v1.0.21`
 1:39.23 Caused by:
 1:39.23   could not execute process `C:\mozdev\mozilla-unified\obj-x86_64-pc-mingw32\testing\geckodriver\.\release\build\quote-757e7995f51b41ec\build-script-build` (never executed)
 1:39.23 Caused by:
 1:39.23   The system cannot find the file specified. (os error 2)
 1:39.23 warning: build failed, waiting for other jobs to finish...
 1:39.62 dom/filehandle
 1:40.15    Compiling proc-macro2 v1.0.43
 1:40.52    Compiling quote v1.0.21
 1:40.54 dom/filesystem/compat
 1:41.12 error: failed to run custom build command for `proc-macro2 v1.0.43`
 1:41.12 Caused by:
 1:41.12   could not execute process `C:/mozdev/mozilla-unified/obj-x86_64-pc-mingw32\release\build\proc-macro2-b918a48bcbfc3457\build-script-build` (never executed)
 1:41.12 Caused by:
 1:41.12   The system cannot find the file specified. (os error 2)
 1:41.12 warning: build failed, waiting for other jobs to finish...

At d951d850db, it builds fine; but on the next changeset, 6b9175bbab, I'm seeing this failure; which points to bug 1791476 as the culprit.

I'm assuming that it isn't failing for everyone, so there's something odd about my system. But I don't know what it is.

:glandium, since you are the author of the regressor, bug 1791476, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mh+mozilla)

I ran into this issue while trying to set up a new Windows build environment following the instructions, so I don't think it's setup-specific.

 2:06.35 error: failed to run custom build command for `quote v1.0.21`
 2:06.35 Caused by:
 2:06.35   could not execute process `C:/mozilla-source/mozilla-unified/obj-x86_64-pc-mingw32\release\build\quote-453b32d2dbab4bc3\build-script-build` (never executed)
 2:06.35 Caused by:
 2:06.35   The system cannot find the file specified. (os error 2)

I don't see that build script at all:

$ ls obj-x86_64-pc-mingw32/release/build/quote-453b32d2dbab4bc3
build_script_build-453b32d2dbab4bc3.d

EDIT: Can be worked around by reverse-applying 6b9175bbaba8995fc54eb3da9837cc83b14741fc. I can see the generated build-script-build.exe as well.

I can't reproduce this. Can you attach a full verbose log (mach build -v) after a clobber? Can you also give your mozillabuild version?

Flags: needinfo?(mh+mozilla) → needinfo?(jfkthame)

I can reproduce this, clobber builds take a fair number of minutes on my setup so I'll do that after my current build attempt (trying hg backout -r 6b9175bbaba8995fc54eb3da9837cc83b14741fc to see if it mitigates the issue for me).

Confirmed it builds with hg backout -r 6b9175bbaba8995fc54eb3da9837cc83b14741fc (comment #2). I'll reverse that and get the build log next for folks to poke at and fix the issue.

Attached the build output when I successfully repro the issue.

Attachment #9303425 - Attachment mime type: application/octet-stream → text/plain
Attachment #9303435 - Attachment mime type: application/octet-stream → text/plain

It's probably redundant, as Ashley has already provided a log, but for completeness here's one from my system as well. This is with mozilla-build 4.0.2 and with Rust nightly toolchain.

Flags: needinfo?(jfkthame)

I am also hitting this error after a full clobber, and reverting that change lets me build. Let me know if you want anything from my machine.

Set release status flags based on info from the regressing bug 1791476

Is anyone that can reproduce this running Windows in a VM?

Considering the difficulty to figure out what's going wrong because none
of members of the build team can reproduce this, and considering that
the problem bug 1791476 addresses only affects TSAN for the moment, and
TSAN is not supported on Windows, let's just go back to what the linker
wrapper was before bug 1791476 on Windows, which will at least unblock
people.

We'll eventually have to figure out what's going wrong, but that's for
another day.

Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/659083b7858b
Revert the Windows part of bug 1791476. r=firefox-build-system-reviewers,andi
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(mh+mozilla)
Blocks: mach-busted
No longer blocks: 1791476
Flags: needinfo?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: