Closed Bug 1800564 Opened 2 years ago Closed 2 years ago

./mach try chooser is broken

Categories

(Firefox Build System :: Mach Core, defect)

Product:
Firefox Build System
Component:
Mach Core
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: adw, Assigned: ahochheiden)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

mach.txt
10.13 KB, text/plain
Details
mach2.txt
12.79 KB, text/plain
Details
mach-lint.txt
57.55 KB, text/plain
Details
Attached file mach.txt —

When I run ./mach try chooser I get the attached error output and the chooser doesn't open. The error details are:

The details of the failure are as follows:

mach.site.InstallPipRequirementsException: As part of validation after installing "/Users/adw/mc/tools/tryselect/selectors/chooser/requirements.txt" into the "common" site, the site appears to contain installed packages that are incompatible with each other.

  File "/Users/adw/mc/tools/tryselect/mach_commands.py", line 365, in try_chooser
    command_context.virtualenv_manager.install_pip_requirements(path, quiet=True)
  File "/Users/adw/mc/python/mach/mach/site.py", line 677, in install_pip_requirements
    raise InstallPipRequirementsException(

I can't reproduce. Try after removing /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f and /Users/adw/mc/obj-artifact/_virtualenvs

Flags: needinfo?(adw)

Thanks, but it fails with the same error.

To give some background, I recently had other problems running hg that I think were due to using 6.2 instead of 6.1. I don't know how I suddenly ended up with an incompatible hg version. I might have installed it via my package manager and then updated it recently. Anyway, I fixed it by uninstalling and reinstalling it following the instructions here, and along the way I also uninstalled python2 and reinstalled python3.

I'm using brew on macOS and I know next to nothing about python, so please let me know if I can give you more info. ./mach bootstrap doesn't fix it.

Flags: needinfo?(adw)

I get the same error about blessings when running lint, but unlike try chooser lint seems to finish successfully anyway. The patch in bug 1800056 doesn't fix that. Is this related to https://phabricator.services.mozilla.com/D161858#5324063 and bug 1800056?

Yeah, I think this is a duplicate of bug 1800056. blessed is on the internal PyPi mirror now, so it should work with the patch attached to that bug. Let me know if it doesn't.

Flags: needinfo?(adw)

Though, it does seem a bit odd that in your log it says mozlog 6.0 requires blessings, which is not installed. when the current version of mozlog is 7.1.0.

It still doesn't work. I tried with and without the latest diff in that revision, and I removed the directories Mike mentioned in comment 1. Do I need to do anything else? Do I need to do something w/r/t to the PyPi mirror?

I don't know if it's related but around the time this started happening, all this stuff gets logged on ./mach bootstrap, which has never happened before:

Requirement already satisfied: glean-sdk==51.8.0 in /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f/_virtualenvs/mach/lib/python3.10/site-packages (51.8.0)
Requirement already satisfied: semver>=2.13.0 in /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f/_virtualenvs/mach/lib/python3.10/site-packages (from glean-sdk==51.8.0) (2.13.0)
Requirement already satisfied: glean-parser~=6.3 in /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f/_virtualenvs/mach/lib/python3.10/site-packages (from glean-sdk==51.8.0) (6.3.0)
Requirement already satisfied: appdirs>=1.4 in ./third_party/python/appdirs (from glean-parser~=6.3->glean-sdk==51.8.0) (1.4.4)
Requirement already satisfied: Jinja2>=2.10.1 in ./third_party/python/Jinja2 (from glean-parser~=6.3->glean-sdk==51.8.0) (2.11.3)
Requirement already satisfied: diskcache>=4 in ./third_party/python/diskcache (from glean-parser~=6.3->glean-sdk==51.8.0) (4.1.0)
Requirement already satisfied: MarkupSafe<=2.0.1,>=1.1.1 in ./third_party/python/MarkupSafe/src (from glean-parser~=6.3->glean-sdk==51.8.0) (1.1.1)
Requirement already satisfied: jsonschema>=3.0.2 in ./third_party/python/jsonschema (from glean-parser~=6.3->glean-sdk==51.8.0) (3.2.0)
Requirement already satisfied: yamllint>=1.18.0 in ./third_party/python/yamllint (from glean-parser~=6.3->glean-sdk==51.8.0) (1.23.0)
Requirement already satisfied: PyYAML>=5.3.1 in ./third_party/python/PyYAML/lib3 (from glean-parser~=6.3->glean-sdk==51.8.0) (5.4.1)
Requirement already satisfied: Click>=7 in ./third_party/python/click (from glean-parser~=6.3->glean-sdk==51.8.0) (7.1.2)
Requirement already satisfied: six>=1.11.0 in ./third_party/python/six (from jsonschema>=3.0.2->glean-parser~=6.3->glean-sdk==51.8.0) (1.13.0)
Requirement already satisfied: attrs>=17.4.0 in ./third_party/python/attrs (from jsonschema>=3.0.2->glean-parser~=6.3->glean-sdk==51.8.0) (19.2.0)
Requirement already satisfied: setuptools in ./third_party/python/setuptools (from jsonschema>=3.0.2->glean-parser~=6.3->glean-sdk==51.8.0) (51.2.0)
Requirement already satisfied: pyrsistent>=0.14.0 in ./third_party/python/pyrsistent (from jsonschema>=3.0.2->glean-parser~=6.3->glean-sdk==51.8.0) (0.16.0)
Requirement already satisfied: pathspec>=0.5.3 in ./third_party/python/pathspec (from yamllint>=1.18.0->glean-parser~=6.3->glean-sdk==51.8.0) (0.9.0)
Requirement already satisfied: psutil<=5.8.0,>=5.4.2 in /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f/_virtualenvs/mach/lib/python3.10/site-packages (5.8.0)
Requirement already satisfied: zstandard<=0.17.0,>=0.11.1 in /Users/adw/.mozbuild/srcdirs/mc-b24acae1fd2f/_virtualenvs/mach/lib/python3.10/site-packages (0.17.0)
Flags: needinfo?(adw)

It works after reverting to the parent of the first revision in bug 1744340, although there's still a ton of stuff logged that wasn't before. It doesn't work after reverting to the last revision in that bug.

Do I need to do anything (as a Mac user?) to update my system?

Ah, there's still some deps missing on the PyPi mirror. I'll get them added.

Does it work for you now? If not, can you paste the error log?

Flags: needinfo?(adw)
Attached file mach2.txt —

No, nothing's changed. Not sure it matters but I tried with the latest diff in https://phabricator.services.mozilla.com/D161858. I'll attach my terminal output after rm'ing the directories above and running try chooser.

Flags: needinfo?(adw)
Attached file mach-lint.txt —

This is after running ./mach lint --outgoing --warnings --fix. It completes successfully but there are a ton of things logged including the same mach.site.InstallPipRequirementsException from try chooser.

I can see mozlog 6.0 in mozlint here and I'm guessing it will work if that's set to 7.1.1 and once :ahal pushes mozlog 7.1.1 to PyPi.

Assignee: nobody → ahochheiden
Status: NEW → ASSIGNED

See bug 1801153 comment 7 for the potential workaround.

I think the changes I referenced in my previous comment are not necessary to workaround the bug seen here.

See Also: → 1801153

Awesome, thanks Alex. I left a comment in that bug.

Attachment #9304024 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

This should be fixed by D162807 which landed in bug 1801153.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: