Closed Bug 1800828 Opened 1 year ago Closed 1 year ago

In Ja build, Font size of Advanced font settings is not correctly displayed (not wide enough for display)

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Version:
Firefox 108
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
109 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox107 --- unaffected
firefox108 + verified
firefox109 --- verified

People

(Reporter: alice0775, Assigned: emilio)

References

(Regression)

Details

(Keywords: nightly-community, regression)

Attachments

(6 files)

screenshot
218.09 KB, image/png
Details
screenshot: Nightly buildID:20221117093901
148.29 KB, image/png
Details
font
451.62 KB, image/png
Details
Bug 1800828 - Simplify markup of fonts dialog. r=Gijs
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
Bug 1800828 - Make labels for font dialog not wrap. r=Gijs
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
Bug 1800828 - Fix padding of preferences dialog. r=Gijs
48 bytes, text/x-phabricator-request
diannaS
: approval-mozilla-beta+
Details | Review
Attached image screenshot —

[Tracking Requested - why for this release]: Localized build [Ja] UI is Broken

Steps to reproduce:

  1. Start Ja build Nightly
  2. Open about:preferences
    General settings > Language & Appearance > Fonts & Colors > "Advanced..." button

Actual results:
Size is not correctly displayed numerically (not wide enough for display)
See attached screenshot.

Expected results:
Size should be correctly indicated numerically.

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ca2873779214f6109ffe1b23e1455350294ac325&tochange=59fa65e9da080d96cf90d9c99a458372b8d58b4d

Suspect:
6c60375237864880161d4a8915408e68ec28d1e3 Emilio Cobos Álvarez — Bug 1779695 - Use modern flex on in-content pages.

status-firefox109: --- → affected
See Also: → 1800747

:emilio, since you are the author of the regressor, bug 1779695, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Alice, does bug 1799460 fix this? I believe it should. I couldn't repro this neither on Windows 11 nor Linux. If bug 1799460 fixed this, then I can land a one-liner to revert to the previous behavior on Windows for beta.

Thanks!

Flags: needinfo?(emilio) → needinfo?(alice0775)

You may need zoom out to 80% to reproduce the issue.

Steps to reproduce:

  1. Start Ja build Nightly
  2. Open about:preferences
  3. Zoom out (80%) (Ctrl+- twice)
  4. General settings > Language & Appearance > Fonts & Colors > "Advanced..." button
Flags: needinfo?(alice0775) → needinfo?(emilio)

Can't repro at any zoom level either, might be due to different fonts... Can you confirm whether bug 1799460 fixes it on the next nightly?

Flags: needinfo?(emilio) → needinfo?(alice0775)

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Can you confirm whether bug 1799460 fixes it on the next nightly?

I can still reproduce the issue on Nightly buildID:20221117093901.
(a little bit improved, but only the tens digit is displayed.)

Flags: needinfo?(alice0775)
Attached image font —

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Can't repro at any zoom level either, might be due to different fonts...

The system font is "Segoe UI" and the Japanese font seems to fall back to "Meiryo" on my Win10.

Flags: needinfo?(emilio)

This doesn't fix the bug but removes some unnecessary elements (now that the
prefs search was improved), and moves some CSS out of inline styles into
already-existing rules.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Use max-content sizing for them. This matches the XUL behavior.

Depends on D162342

After making preferences dialogs use modern flexbox XUL behaves like html, so
use the <dialog> to avoid clipping stuff vertically, since that's presence in
both <html> and <window>-based dialogs:

$ rg -l '<dialog' browser/components/preferences/dialogs/*.xhtml | wc -l
18
$ ls -la browser/components/preferences/dialogs/*.xhtml | wc -l
18

Depends on D162343

Flags: needinfo?(emilio)
Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f3200568c4e
Fix padding of preferences dialog. r=desktop-theme-reviewers,dao
Keywords: leave-open
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a5582aaf59b
Simplify markup of fonts dialog. r=Gijs,settings-reviewers
https://hg.mozilla.org/integration/autoland/rev/757a7e956387
Make labels for font dialog not wrap. r=desktop-theme-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/2f3200568c4e

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox109: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

The issue was fixed. No longer reproduce on Nightly109.0a1(20221120214001)

status-firefox109: fixed → verified

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9303984 [details]
Bug 1800828 - Simplify markup of fonts dialog. r=Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively straight-forward and targeted refactorings / fixes.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9303984 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9303985 [details]
Bug 1800828 - Make labels for font dialog not wrap. r=Gijs

Beta/Release Uplift Approval Request

  • User impact if declined: See above.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): see above
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9303985 - Flags: approval-mozilla-beta?
Attachment #9303986 - Flags: approval-mozilla-beta?

Comment on attachment 9303984 [details]
Bug 1800828 - Simplify markup of fonts dialog. r=Gijs

Approved for 108.0b5

Attachment #9303984 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9303985 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9303986 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Hi, Alice0775 White! Could you please help us verify this issue on Beta 108 as well? I am not able to reproduce the bug on Win 10 x64, by following your STR from comment 3, on an affected Nightly "ja" build 109.0a1, 2022-11-15.

Flags: needinfo?(alice0775)

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #20)

Hi, Alice0775 White! Could you please help us verify this issue on Beta 108 as well? I am not able to reproduce the bug on Win 10 x64, by following your STR from comment 3, on an affected Nightly "ja" build 109.0a1, 2022-11-15.

The issue was fixed. No longer reproduce on Firefox108.0b5(20221122190120)

Status: RESOLVED → VERIFIED
status-firefox108: fixed → verified
Flags: needinfo?(alice0775)

Thank you!

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: