1801040 - Allow makeSideeffectFreeDebugger to only bail for effectful native function

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Since ClojureScript formatters are creating and updating global variable, the current eager evaluation bails, making the formatters useless.

Since the purpose of custom formatters are slightly different from instant evalation, we can probably loosen our restriction when executing the hooks and only bailing if effectful native function are called

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1801040 - Added option to makeSideeffectFreeDebugger() to skip checking effectful offsets. r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/668624c2b096
Added option to makeSideeffectFreeDebugger() to skip checking effectful offsets. r=nchevobbe

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1801045 for causing failures on browser_webconsole_object_inspector_custom_formatters.js

• backout: https://hg.mozilla.org/integration/autoland/rev/eccf45ab489fec65ccf8460acab684f8df8ea564

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/331045c29420
Added option to makeSideeffectFreeDebugger() to skip checking effectful offsets. r=nchevobbe

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/331045c29420