1801045 - Don't use ObjectInspector to render custom formatted values

Status: RESOLVED FIXED

(DevTools :: Object Inspector, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

The methods we use to get and display the children of a given object don't match with how custom formatter body works, so it should be handled separately

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 1801045 - Replaced ObjectInspector handling for custom formatter output by separate one. r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff58ef6ef9ae
Replaced ObjectInspector handling for custom formatter output by separate one. r=nchevobbe

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out along with Bug 1801040 for causing failures on browser_webconsole_object_inspector_custom_formatters.js

• backout: https://hg.mozilla.org/integration/autoland/rev/eccf45ab489fec65ccf8460acab684f8df8ea564
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=UzDlsA6_SSu12DUChEeL0w.0&revision=ff58ef6ef9ae6ed35254b3dfbb4349b947335446
• failure log: https://treeherder.mozilla.org/logviewer?job_id=396821515&repo=autoland&lineNumber=9291

[task 2022-11-17T10:09:22.056Z] 10:09:22     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js | The custom formatting of the header is correct - 
[task 2022-11-17T10:09:22.057Z] 10:09:22     INFO - Simple test for custom formatted header with body
[task 2022-11-17T10:09:22.057Z] 10:09:22     INFO - Buffered messages finished
[task 2022-11-17T10:09:22.059Z] 10:09:22     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js | The message is custom formatted - 
[task 2022-11-17T10:09:22.060Z] 10:09:22     INFO - Stack trace:
[task 2022-11-17T10:09:22.060Z] 10:09:22     INFO - chrome://mochikit/content/browser-test.js:test_ok:1457
[task 2022-11-17T10:09:22.061Z] 10:09:22     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js:testCustomFormatting:87
[task 2022-11-17T10:09:22.061Z] 10:09:22     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js:testObjectWithFormattedHeaderAndBody:64
[task 2022-11-17T10:09:22.062Z] 10:09:22     INFO - chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js:null:25
[task 2022-11-17T10:09:22.062Z] 10:09:22     INFO - chrome://mochikit/content/browser-test.js:handleTask:1045
[task 2022-11-17T10:09:22.063Z] 10:09:22     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1117
[task 2022-11-17T10:09:22.063Z] 10:09:22     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1252
[task 2022-11-17T10:09:22.063Z] 10:09:22     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1034
[task 2022-11-17T10:09:22.064Z] 10:09:22     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1036
[task 2022-11-17T10:09:22.064Z] 10:09:22     INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_custom_formatters.js | The variable 'formatted' must be unchanged - 0 == 0 - 

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

my bad, I'll have a look at those

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d0360568cfa
Replaced ObjectInspector handling for custom formatter output by separate one. r=nchevobbe

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/7d0360568cfa