1801318 - Unified extension button panel remains open when activating uBlock Origin “Block Element” function from the context menu

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P2)

Description

[Alex Cornestean]

Attachment: 2022-11-18_16h21_08.mp4

Affected versions:
Nightly – 109.0a1/20221118094451

Description:
The unified extensions button panel does not close on activating uBlock Origin’s “Block Element” from either the right click context menu (right click on the add-on entry in the unified extension panel) or from the gear context menu.

This is appears to be a per-existing issue, as the same behavior can be observed with the Overflow Menu panel on the current Beta 108.0b3 and Release 107.0 when performing the above actions.

Steps to reproduce:

1. Install uBlock Origin
2. Move the add-on button to the UEB (unified extension button) panel
3. Open the context menu (either by right clicking the extension entry or clicking the gear button)
4. Select “Block Element”
5. Notice the UEB panel does not close

Actual:
The UEB panel does not close on activating the “Block Element” function.

Expected:
The UEB panel should close on activating the “Block Element” function.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1801318 - Close context menu on command. r?mconley!

This will force the panel to close when we click an item in the context
menu, without having to handle each menu item separately.

Depends on D162414

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ce1a8e7263d
Close context menu on command. r=mconley

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7ce1a8e7263d

Comment 4

[Alex Cornestean]

Verified as Fixed on the latest Nightly (109.0a1/20221122214324). Tested on Windows 10 x64 and Ubuntu 16.04 LTS.

The UEB panel now closes when the context menu “Block Element” option is selected.

For further details, see the attached video.

Comment 5

[Alex Cornestean]

Attachment: 2022-11-23_08h43_37.mp4