1801433 - Cleanup: Remove PresShell::GetAccessibilityService/IsAccessibilityActive

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Spun off https://phabricator.services.mozilla.com/D162263#inline-895099

GetAccessibilityService was added in bug 628922 in the days when there was a lot more XPCOM. These days, it just redirects to GetAccService, which seems like unnecessary indirection. IsAccessibilityActive also just calls GetAccService. We should remove these methods and just call GetAccService directly.

Also, I notice that PresShell.h includes nsAccessibilityService.h, but also forward declares nsAccessibilityService. We should try to remove the include if possible.

Comment 1

[James Teh [:Jamie]]

(In reply to James Teh [:Jamie] from comment #0)

Also, I notice that PresShell.h includes nsAccessibilityService.h, but also forward declares nsAccessibilityService. We should try to remove the include if possible.

Ah, we can't because it's needed in ~AutoSaveRestoreRenderingState. See bug 1726227.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1801433: Remove PresShell::GetAccessibilityService/IsAccessibilityActive.

These have just called GetAccService for a long time now, so callers should just call that directly.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5abf34dbe421
Remove PresShell::GetAccessibilityService/IsAccessibilityActive. r=emilio

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5abf34dbe421