Closed
Bug 180147
Opened 22 years ago
Closed 22 years ago
[gtk2] need to port over the null plugin
Categories
(Core :: XUL, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: blizzard, Assigned: iamawalrus)
References
Details
Attachments
(2 files, 1 obsolete file)
|
2.09 KB,
patch
|
iamawalrus
:
review+
bryner
:
superreview+
|
Details | Diff | Splinter Review |
|
1.24 KB,
patch
|
blizzard
:
review+
bryner
:
superreview+
asa
:
approval1.3a-
|
Details | Diff | Splinter Review |
Need to port over the null plugin code.
Attachment #106621 -
Flags: review?(blizzard)
|
Reporter | |
Comment 3•22 years ago
|
||
Have to include the parent makefile as well.
Attachment #106621 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•22 years ago
|
Attachment #106914 -
Flags: superreview?(bryner)
Attachment #106914 -
Flags: review?(robin.lu)
|
|
Reporter | |
Updated•22 years ago
|
Attachment #106621 -
Flags: review?(blizzard) → review-
|
||
Updated•22 years ago
|
Attachment #106914 -
Flags: superreview?(bryner) → superreview+
Attachment #106914 -
Flags: review?(robin.lu) → review+
checked in. wow... first patch checked in by myself.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Comment 5•22 years ago
|
||
This added a warning on brad TBox:
+modules/plugin/samples/default/unix/nullplugin.c:374
+ `style' might be used uninitialized in this function
which is weird - can it be thst neither MOZ_ENABLE_GTK nor MOZ_ENABLE_GTK2 are
enambled?
P.S. According to bug 179819 these warning ought to be treated as compilation
errors...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Thank Aleksey Nogin for finding this warning. You are quite right. This is an
error indeed. I found the MOZ_ENABLE_GTK2 is not defined. I should have been
more careful.
This is the new patch. seeking r=?
Attachment #107326 -
Flags: review?(blizzard)
|
|
Reporter | |
Comment 8•22 years ago
|
||
Comment on attachment 107326 [details] [diff] [review]
patch
r=blizzard
Attachment #107326 -
Flags: review?(blizzard) → review+
Attachment #107326 -
Flags: superreview?(bryner)
Attachment #107326 -
Flags: approval1.3a?
|
||
Comment 9•22 years ago
|
||
Comment on attachment 107326 [details] [diff] [review]
patch
1.3a is complete. not taking further patches.
Attachment #107326 -
Flags: approval1.3a? → approval1.3a-
|
Assignee | |
Comment 10•22 years ago
|
||
Asa,
this patch fixes a regression of the previous patch of this bug. The regression
may cause random problem in nullplugin of either gtk1.2 or gtk2.0. Can you
re-consider this?
|
|
||
Updated•22 years ago
|
Attachment #107326 -
Flags: superreview?(bryner) → superreview+
|
|
Assignee | |
Comment 11•22 years ago
|
||
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
|
||
Comment 12•22 years ago
|
||
null plugin doesn't work for me any more since I use GTK+ 2.2.0.
I get th following message on startup:
LoadPlugin: failed to initialize shared library
/opt/mozilla/lib/mozilla-1.2.1/plugins/libnullplugin.so
[/opt/mozilla/lib/mozilla-1.2.1/plugins/libnullplugin.so: undefined symbol:
gdk_display]
|
||
Comment 13•22 years ago
|
||
$ nm libgdk-x11-2.0.so.0.200.0 | grep '\<gdk_display\>'
0005f568 D gdk_display
You need to log in
before you can comment on or make changes to this bug.
Description
•