1801502 - When the overflow panel overflows, the scrollbar overlaps a portion of the menuitems

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Screenshot

This is especially visible when the extension menuitems are in there.
(Also, no pun intended for this bug summary!)

Comment 1

[William Durand [:willdurand]]

It seems that we no longer need to set the width on the .widget-overflow-list element and simply removing it fixes this bug. I only poked around with Itiel but that does not seem to have any unwanted side effects.

:emilio given this looks like a trivial fix and the bug makes the "new" extension widget UI look bad (as shown in Comment 0), could we fix this bug and request an uplift to 108 please?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Given you've debugged this and pretty much provided a patch, can you send it to phab? Happy to r+ it, and yeah it should be trivial enough to uplift.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1790616

Comment 4

[William Durand [:willdurand]]

Attachment: Bug 1801502 - Fix overflow panel when it overflows. r?emilio!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2c628738330
Fix overflow panel when it overflows. r=emilio,desktop-theme-reviewers,Itiel

Comment 6

[William Durand [:willdurand]]

I just noticed that my (git) user name wasn't set up correctly on my windows machine (which I don't normally use to submit patches). That means the patch above landed with "unknown" as author name (sigh), not a big deal but would be nice to fix that for the uplift to 108.

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d2c628738330

Comment 8

[William Durand [:willdurand]]

Comment on attachment 9304276 [details]
Bug 1801502 - Fix overflow panel when it overflows. r?emilio!

Beta/Release Uplift Approval Request

• User impact if declined: Windows users who use the overflow panel heavily (with many widgets in there, including extensions). Clearly not the vast majority of users but the UI looks bad when that happens.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not risky because it is a trivial CSS change on the overflow panel and we made sure to only fix the UI bug and defer clean-ups in follow-up patches.
• String changes made/needed:
• Is Android affected?: No

PS: when grafting this patch, can you please fix up the author name (unknown => William Durand)? (assuming that's possible) Thanks!

Comment 9

[Alex Cornestean]

Verified as Fixed on the latest Nightly (109.0a1/20221121093640). Tested on Windows 10 x64 and Ubuntu 16.04 LTS (although Linux was not affected to begin with).

When the overflow panel overflows, the scrollbar no longer overlaps a portion of the menu items, confirming the fix.

For further details, see the attached screenshots.

Comment 10

[Alex Cornestean]

Attachment: Windowss.png

Comment 11

[Alex Cornestean]

Attachment: Linux.png

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9304276 [details]
Bug 1801502 - Fix overflow panel when it overflows. r?emilio!

Approved for 108.0b5

Comment 13

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6cae332e0e1d

Comment 14

[Alex Cornestean]

Verified as Fixed on the latest Beta (108.0b5/20221122190120). Tested on Windows 10 x64 and Ubuntu 16.04 LTS (although Linux was not affected to begin with).

When the overflow panel overflows, the scrollbar no longer overlaps a portion of the menu items, confirming the fix.

For further details, see the attached screenshot.

Comment 15

[Alex Cornestean]

Attachment: 2022-11-23_08h57_43.png