1801956 - Fix titlebar button detection in nsBoxFrame::BuildDisplayList.

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

While looking at the code in bug 1798396, I realized there's another piece of code that doesn't work on non-XUL frames, and that powers features like bug 1718629.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1801956 - Move titlebar button handling out of nsBoxFrame. r=tnikkel

This fixes the snap layouts feature on Windows 11.

Instead of using a content attribute (which is somewhat expensive to
look up) use the default appearance and do this where we deal with other
appearance hacks (before building themed backgrounds).

Consolidate this inside a DealWithWindowsAppearanceHacks function along
with the glass stuff.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98ad3f08cb4c
Move titlebar button handling out of nsBoxFrame. r=tnikkel

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/98ad3f08cb4c

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9304777 [details]
Bug 1801956 - Move titlebar button handling out of nsBoxFrame. r=tnikkel

Beta/Release Uplift Approval Request

• User impact if declined: Windows 11 snap layout features don't work.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug 1718629 for examples
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple refactoring to fix 108 regression.
• String changes made/needed: none
• Is Android affected?: No

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9304777 [details]
Bug 1801956 - Move titlebar button handling out of nsBoxFrame. r=tnikkel

Approved for 108.0b8

Comment 6

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81713ddca0e0

Comment 7

[Ciprian Georgiu, Desktop QA]

I've reproduced this bug on an affected Nightly build, 109.0a1 (20221122214324), the snap layout feature did not work on Win 11.

I've verified that the snap layout feature works as expected on the latest builds, Beta 108.0b9 and Nightly 109.0a1, running Win 11 x64.