Closed Bug 1801956 Opened 2 years ago Closed 2 years ago

Fix titlebar button detection in nsBoxFrame::BuildDisplayList.

Categories

(Core :: XUL, defect)

defect

Tracking

()

VERIFIED FIXED
109 Branch
Tracking Status
firefox108 --- verified
firefox109 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

While looking at the code in bug 1798396, I realized there's another piece of code that doesn't work on non-XUL frames, and that powers features like bug 1718629.

This fixes the snap layouts feature on Windows 11.

Instead of using a content attribute (which is somewhat expensive to
look up) use the default appearance and do this where we deal with other
appearance hacks (before building themed backgrounds).

Consolidate this inside a DealWithWindowsAppearanceHacks function along
with the glass stuff.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98ad3f08cb4c
Move titlebar button handling out of nsBoxFrame. r=tnikkel
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 109 Branch

Comment on attachment 9304777 [details]
Bug 1801956 - Move titlebar button handling out of nsBoxFrame. r=tnikkel

Beta/Release Uplift Approval Request

  • User impact if declined: Windows 11 snap layout features don't work.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See bug 1718629 for examples
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively simple refactoring to fix 108 regression.
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9304777 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9304777 [details]
Bug 1801956 - Move titlebar button handling out of nsBoxFrame. r=tnikkel

Approved for 108.0b8

Attachment #9304777 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I've reproduced this bug on an affected Nightly build, 109.0a1 (20221122214324), the snap layout feature did not work on Win 11.

I've verified that the snap layout feature works as expected on the latest builds, Beta 108.0b9 and Nightly 109.0a1, running Win 11 x64.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Regressions: 1809061
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: