1718629 - Windows 11 Snap Layouts menu doesn't appear while hovering

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[kristoffer]

Attachment: How Snap Layouts is supposed to appear while hovering

When hovering the maximize/minimize window button on Windows 11, a hover menu to snap the window is supposed to appear.

On Firefox 91, the Snap Layouts hover menu doesn't appear.

Comment 1

[kristoffer]

Attachment: Hovering the Firefox Snap Layouts location

Comment 2

[pablo.r.arevalo]

Win 11 snap menu will show if you customize the toolbar and force the titlebar to show, but will stop working if you hide the titlebar. Needs a workaround for those of us that prefer to hide the titlebar.

Comment 3

[alan]

Windows Terminal also uses a custom title bar. This is the GitHub issue tracking this: https://github.com/microsoft/terminal/issues/9443

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

It seems HTMAXBUTTON should be supported in https://searchfox.org/mozilla-central/rev/58e60ad5973c16db4977cdd8e31012280d5915b8/widget/windows/nsWindow.cpp#6363.

Comment 6

[alex_mayorga]

[Tracking Requested - why for this release]: Per https://www.microsoft.com/en-us/windows/windows-11 "Windows 11 isn’t here yet, but will be coming later this year. "

¡Hola y'all!

Hope these lines find you well.

Confirming this bug as it has been confirmed by multiple users in:

• Reddit: https://www.reddit.com/r/firefox/comments/oamjyl/snap_layouts_in_windows_11_not_working/ and
• SuMo: https://support.mozilla.org/questions/1348862

Found some workarounds:

• press Win + Z for the snap options to appear
• enable the "Title bar" in the UI customization so the snap options appear when hovering

I can also confirm this bug exists on Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:93.0) Gecko/20100101 Firefox/93.0 ID:20210829092700

¡Gracias!
Alex

Comment 8

[David Parks [:handyman]]

Attachment: Bug 1718629: Handle Windows WM_NCHITTEST message for maximize button r=emilio!,cmartin!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e03c235c93c8
Handle Windows WM_NCHITTEST message for maximize button r=emilio,cmartin

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e03c235c93c8

Comment 11

[Pascal Chevrel:pascalc]

David, should we uplift that to beta? Windows 11 is announced to ship when we ship 93 on October 5.

Comment 12

[David Parks [:handyman]]

Uplift is a good idea and I'm pretty sure this is fine for it but I want to give it a day or two on nightly first. (I'll leave the NI open for now.)

Comment 13

[Pascal Chevrel:pascalc]

David, do we want to uplift that patch and the fixes for the regressions it caused into beta or is that too risky and we should let it ride the 94 train? Thanks

Comment 14

[Masatoshi Kimura [:emk]]

If we uplift this patch, we will also have to uplift patches for follow-up bugs (1729742, 1729749, 1730312, and 1730309) including not yet resolved one.

Comment 15

[David Parks [:handyman]]

Bug 1730309 is a regression that is still active and looks like its going to expand the complexity in the patch series so uplift isn't a good idea.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:handyman, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
If yes, don't forget to request an uplift for the patches in the regressions caused by this fix.

For more information, please visit auto_nag documentation.

Comment 17

[Pascal Chevrel:pascalc]

Too late for 93

Comment 19

[Ciprian Georgiu, Desktop QA]

This bug is verified as fixed on latest Beta 94.0b5 under Win 11. I can confirm that snap layouts are correctly displayed, and the functionally is working as expected.

Comment 20

[Gian-Carlo Pascutto [:gcp]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New Windows 11 feature that we didn't support previously
[Affects Firefox for Android]: No.
[Suggested wording]: Firefox now supports the new Snap Layouts menus when running on Windows 11.
[Links (documentation, blog post, etc)]: Only this bug.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Added to the final Fx94 relnotes. Also, I don't think this is worth backporting to ESR91, so marking that wontfix while I'm here.