180215 - [spam] initial size of junk mail controls dialog is huge

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

[spam] initial size of junk mail controls dialog is huge

this might be fixed by neils patch at 
http://bugzilla.mozilla.org/attachment.cgi?id=105964&action=edit

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch v2

Updated version of Neil's patch.  Two changes: 

* fix a syntax error and also add a forgotten ; in junkMail.xul
* remove a function which is no longer necessary from junkMail.js

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 106869 [details] [diff] [review]
patch v2

r=dmose

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 106869 [details] [diff] [review]
patch v2

sr=sspitzer

assuming we don't have the "blank on second time problem"

thanks to neil for the patch, and thanks to dmose for testing, cleaning up, and
landing.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Fix checked in; thanks for the patch, Neil!

Comment 5

[R.K.Aa.]

*** Bug 181267 has been marked as a duplicate of this bug. ***

Comment 6

[laurel]

OK using nov22 commercial trunk: win98, mac OS 10.2, linux rh8

Comment 7

[NorthMan]

I just upgraded to win32 WinME build 2002112208, and the junk mail controls
window is huge.  I resized it, closed the window, and reopened it, and it's huge
again.  I don't see the fixed part...

Comment 8

[laurel]

Yes, confirmed this is back in 12-02 commercial trunk build: win2000.
I don't however, have the same problem on Mac OS 10.2 or win98, both with new
profiles and mac was freshly installed on the machine (wiped out old registry
and such). Didn't try linux yet.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Neil: this is back for me too.  Any ideas what could be going on here?

Comment 10

[NorthMan]

I can still reproduce this on trunk 2003010908 Win32 Millenium.

Comment 11

[(not reading, please use [e-mail] instead)]

taking, but neil, if you have cycles to investigate, that would be great.

Comment 12

[Andreas Kunz]

>   -        persist="screenX screenY width height">

Why was this removed?
At least after the window is nicer sized by the user that new size/shape would
stay the same.
(Related: bug 145941 - although I understand that junk mail controls is now a
dialog and not a window. Maybe that makes a difference... (?))

Comment 13

[NorthMan]

This is fixed for me - 2003031208

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: screen shot, from bryner: "This takes up the entire width of my screen (1152 pixels). "

Comment 15

[(not reading, please use [e-mail] instead)]

I don't see this on win32, but bryner is seeing it on linux.

Comment 16

[(not reading, please use [e-mail] instead)]

esther, do you see this on linux?

Comment 17

[Andreas Kunz]

Well, I'm not esther, but I can tell that I do not see this with 2003032505 on
Linux (KDE, SuSE 8.1) anymore. 
Just created a new profile and tested and so on...
(I also do not see this on Win2k anymore - and yes, I'm sure some weeks ago I
still saw it.)

Comment 18

[Samir Gehani]

Mail triage team: need info.  Esther to check if this is still an issue.

Comment 19

[esther]

I can't reproduce this on my linux system with build 20030326.  Red Hat 7.2 

Comment 20

[esther]

I can't reproduce this on winxp with build 20030326. New profile .

Comment 21

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 22

[Matthias Bockelkamp]

Attachment: new patch v1

I don't know why, but it works for me (WinXP, Mozilla/5.0 (Windows; U; Windows
NT 5.1; en-US; rv:1.5b) Gecko/20030901).

Comment 23

[[e-mail]]

Comment on attachment 131043 [details] [diff] [review]
new patch v1

Actually you could probably completely remove the id.

Comment 24

[Matthias Bockelkamp]

Attachment: new patch v2

Remove the ID completely.

Comment 25

[David :Bienvenu]

Comment on attachment 131148 [details] [diff] [review]
new patch v2

sr=bienvenu

Comment 26

[Matthias Bockelkamp]

Comment on attachment 131148 [details] [diff] [review]
new patch v2

This is a very small but useful change with very low risk, so I'm asking for
approval.

Comment 27

[[e-mail]]

Fix checked in to the trunk, leaving open for possible branch fix.

Comment 28

[Joe Infla]

*** Bug 214931 has been marked as a duplicate of this bug. ***

Comment 29

[Stefan Borggraefe]

Why was the feature to save the size and position of the Junk Mail Controls
window removed? (See also comment #12)

Comment 30

[Matthias Bockelkamp]

I don't know why, but the Search Messages window also doesn't have it.

Comment 31

[[e-mail]]

Originally the dialog appeared with the width of your screen, which was a bit of
a bug. It was then fixed to a proper width, and made nonresizable, but that
affected people who had already used it. So that was fixed too. If you want to
be able to save its position then IMHO that's a separate request.

Comment 32

[Stefan Borggraefe]

Neil: The Junk Mail Controls dialog is still resizable in build 20030912. So I
think it should remember its size and position. I filed Bug 219239 about this.

Comment 33

[Asa Dotzler [:asa]]

Comment on attachment 131148 [details] [diff] [review]
new patch v2

a=asa (on behalf of drivers) for checkin to the Mozilla 1.5 branch. Please add
the fixed1.5 keyword when this is landed on the branch. Thanks.

Comment 34

[[e-mail]]

Whoops, forgot to mark this fixed on branch and trunk.

Comment 35

[Matthias Bockelkamp]

v