3.84 KB, patch
(not reading, please use firstname.lastname@example.org instead): superreview+
|Details | Diff | Splinter Review|
18.48 KB, image/png
886 bytes, patch
|Details | Diff | Splinter Review|
[spam] initial size of junk mail controls dialog is huge this might be fixed by neils patch at http://bugzilla.mozilla.org/attachment.cgi?id=105964&action=edit
15 years ago
Created attachment 106869 [details] [diff] [review] patch v2 Updated version of Neil's patch. Two changes: * fix a syntax error and also add a forgotten ; in junkMail.xul * remove a function which is no longer necessary from junkMail.js
Comment on attachment 106869 [details] [diff] [review] patch v2 r=dmose
Comment on attachment 106869 [details] [diff] [review] patch v2 sr=sspitzer assuming we don't have the "blank on second time problem" thanks to neil for the patch, and thanks to dmose for testing, cleaning up, and landing.
Fix checked in; thanks for the patch, Neil!
*** Bug 181267 has been marked as a duplicate of this bug. ***
OK using nov22 commercial trunk: win98, mac OS 10.2, linux rh8
I just upgraded to win32 WinME build 2002112208, and the junk mail controls window is huge. I resized it, closed the window, and reopened it, and it's huge again. I don't see the fixed part...
Yes, confirmed this is back in 12-02 commercial trunk build: win2000. I don't however, have the same problem on Mac OS 10.2 or win98, both with new profiles and mac was freshly installed on the machine (wiped out old registry and such). Didn't try linux yet.
Neil: this is back for me too. Any ideas what could be going on here?
I can still reproduce this on trunk 2003010908 Win32 Millenium.
taking, but neil, if you have cycles to investigate, that would be great.
> - persist="screenX screenY width height"> Why was this removed? At least after the window is nicer sized by the user that new size/shape would stay the same. (Related: bug 145941 - although I understand that junk mail controls is now a dialog and not a window. Maybe that makes a difference... (?))
This is fixed for me - 2003031208
Created attachment 118470 [details] screen shot, from bryner: "This takes up the entire width of my screen (1152 pixels). "
I don't see this on win32, but bryner is seeing it on linux.
esther, do you see this on linux?
Well, I'm not esther, but I can tell that I do not see this with 2003032505 on Linux (KDE, SuSE 8.1) anymore. Just created a new profile and tested and so on... (I also do not see this on Win2k anymore - and yes, I'm sure some weeks ago I still saw it.)
Mail triage team: need info. Esther to check if this is still an issue.
I can't reproduce this on my linux system with build 20030326. Red Hat 7.2
I can't reproduce this on winxp with build 20030326. New profile .
Mail triage team: nsbeta1-
Created attachment 131043 [details] [diff] [review] new patch v1 I don't know why, but it works for me (WinXP, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030901).
Comment on attachment 131043 [details] [diff] [review] new patch v1 Actually you could probably completely remove the id.
Created attachment 131148 [details] [diff] [review] new patch v2 Remove the ID completely.
Comment on attachment 131148 [details] [diff] [review] new patch v2 sr=bienvenu
Comment on attachment 131148 [details] [diff] [review] new patch v2 This is a very small but useful change with very low risk, so I'm asking for approval.
Fix checked in to the trunk, leaving open for possible branch fix.
*** Bug 214931 has been marked as a duplicate of this bug. ***
Why was the feature to save the size and position of the Junk Mail Controls window removed? (See also comment #12)
I don't know why, but the Search Messages window also doesn't have it.
Originally the dialog appeared with the width of your screen, which was a bit of a bug. It was then fixed to a proper width, and made nonresizable, but that affected people who had already used it. So that was fixed too. If you want to be able to save its position then IMHO that's a separate request.
Neil: The Junk Mail Controls dialog is still resizable in build 20030912. So I think it should remember its size and position. I filed Bug 219239 about this.
Comment on attachment 131148 [details] [diff] [review] new patch v2 a=asa (on behalf of drivers) for checkin to the Mozilla 1.5 branch. Please add the fixed1.5 keyword when this is landed on the branch. Thanks.
Whoops, forgot to mark this fixed on branch and trunk.