1802889 - The "Sync Firefox on your phone or tablet" meesage still displayed even when im already Connected and synced on a mobile phone

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2022-11-28_14h40_40.mp4

Found in

• 109.0a1 (2022-11-28)

Affected versions

• Firefox Nightly 109.0a1 (2022-11-28)
• Beta 108.0b6
• Release 107.0

Preconditions

• Sign in to FXA on a second PC as well as on a Phone. (sync both devices)
• Have the Tab pickup section from Fx View populated.

Affected platforms

• Windows, Ubuntu, Mac

Steps to reproduce

1. Reach the FX View page and make sure that the Pickup tabs are populated.
2. Reach Fxa account settings and sign out all other devices except the Mobile phone. (including the Device currently signed in)
3. Sign back in from the page and then Sign in to FXA as well (from the hamburger menu).
4. Reach the Firefox View tab.
5. Reach any other website on the mobile phone.

Expected result

• Tab pickup section should populate with all the tabs from the Mobile phone.

Actual result

• The "Sync Firefox on your phone or tablet" message is displayed.
• The "Sync Firefox on your phone or tablet" message will only disappear after logging back on a different desktop machine.

Regression range
This issue is not a regression.

Comment 1

[Sarah Clements [:sclements]]

I haven't been able to reproduce this on Nightly 109.0a1 (2022-11-30), although I could reproduce it yesterday. Rares, are you still seeing it?

Comment 2

[Rares Doghi, Desktop QA]

Yes, the issue still occurs in our latest Nightly build : 20221202093401, the trick is to sign out from other devices including the current device and only leave the mobile device connected and synced, after that sign in again from the page as well as from the Hamburger menu.

After reaching the Firefox View page im still being asked to connect.. also reached Youtube on my mobile device and synced again but nothing changes on the Firefox from my desktop machine.

Comment 3

[Sarah Clements [:sclements]]

Going to let someone else pick this up, since my plate is full atm.

Comment 4

[Sarah Clements [:sclements]]

(In reply to Rares Doghi from comment #2)

Yes, the issue still occurs in our latest Nightly build : 20221202093401, the trick is to sign out from other devices including the current device and only leave the mobile device connected and synced, after that sign in again from the page as well as from the Hamburger menu.

After reaching the Firefox View page im still being asked to connect.. also reached Youtube on my mobile device and synced again but nothing changes on the Firefox from my desktop machine.

Ok, yeah, I see it on the latest nightly.

I think what's happening here is something to do with the refreshDeviceList (to refresh the recentDeviceList cache which is used in fx view to determine whether or not to show this screen) not being called/or a notification not firing upon signing to the fxa account. It seemed like this was happening sometimes but potentially not all the times? Or not when signing into the hamburger menu specifically?

Comment 5

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1802889 - Resolve Fx View mobile promo message being incorrectly shown when signing out of current FxA device r=Gijs

Comment 6

[Kelly Cochrane [:kcochrane]]

There are two things I've added in my patch:

• The observers for when FxA devices are connected/disconnected were not added/removed as part of this update: https://phabricator.services.mozilla.com/D153069. Those have now been added.
• When a mobile device is the only synced device beyond the current one (desktop) and you remove the current device (desktop), then sign back in from Fx View Tab Pickup banner, fxAccounts.device.recentDeviceList only returns the mobile device for some reason (possibly due to device cache). This causes our checks for a secondary device to fail (as we now only have access to the mobile device from recentDeviceList, and we're assuming the one device we DO have access to is our current device - which is not the case). This is why Tab Pickup was incorrectly displaying the "Sync Firefox on your phone or tablet" message. I've added a check at the start of refreshDevices() to manually refresh the device list (ignoring device cache) if the recentDeviceList doesn't contain a device with isCurrentDevice set to true. This is really a workaround for the caching stuff going on behind the scenes, but this does seem to fix things from our end.

Update: This appears to happen when any second device is connected, even a second desktop. This workaround seems to fix bug 1804363 also.

Comment 7

[Kelly Cochrane [:kcochrane]]

It looks like bug 1808651 might prevent the need for my manual refreshing of the device list.

Comment 8

[Kelly Cochrane [:kcochrane]]

We've decided to go ahead and land this as a temporary fix until the FxA/Sync team corrects the issue in bug 1808651. We'll be backing out this manual device refresh in bug 1808903 once that fxa/sync fix is in place.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6f06d52eb91
Resolve Fx View mobile promo message being incorrectly shown when signing out of current FxA device r=Gijs

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a6f06d52eb91

Comment 11

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 110.0a1 (2023-01-08). I was able to see the Tabs I reached on my mobile device in the Tab pickup section on my desktop machine.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Too late for today's RC build, but could be nice to get this into an RC respin or dot release down the road. Feel free to nominate (for Release at this point) if you agree.

Comment 14

[Kelly Cochrane [:kcochrane]]

After discussion with Gijs, we decided this is a bit of an edge case, so we're going to wait until 110 to get this out.

Comment 15

[Rares Doghi, Desktop QA]

Updating the main status flag.