1804363 - Tab pickup shows no tabs if only desktop devices are connected to the account until restarting

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Attachment: image.png

STR:

• Sign in to an account that has other desktop devices connected but no mobile devices.

Expected:

• While a CTA to connect a mobile device is expected, it should also be possible to see the tabs from the connected desktop devices.

Actual:

• No tabs are shown, even though the hamburger menu shows them. See screenshot showing both Firefox View (no tabs listed) and the hamburger menu (tabs from the connected desktop device listed)

Comment 1

[Ray Fambro]

This is an interesting issue. Do we know if this is a regression?

Comment 2

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

I've no reason to believe it is a regression.

Comment 3

[Sarah Clements [:sclements]]

Mark, how many desktop devices do you have connected? This should only show if there's one device connected, but we get that information from the fxAccounts.device.recentDeviceList cache. If you do have multiple desktop devices connected, I'm wondering if this is similar to bug 1802889.

Comment 4

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

I can reliably reproduce this, but it does go away when I restart (but not when I refresh Firefox view).

So STR is something like:

• Connect first desktop device to Sync account.
• Connect second desktop device to Sync. After connection, but before restarting, visit Firefox View. Note the screenshot is as above, even after refreshing.
• Restart either profile, problem goes away.

(Reliably reproducing it is probably easiest by opening accounts.firefox.com in a private window, and resetting the account password (even to the same password is fine and makes future reconnection easier). Then reconnect one profile, exit, reconnect the second profile and you will see the above)

edit: note my first repro was doing things "normally" not via a password reset - the password reset note above is just easier than repro'ing with a new account

Comment 5

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

This does look to be resolved with my patch for bug 1802889.

Comment 6

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Mark, do we want to mark this issue as a duplicate of bug 1802889 or just have it be tested alongside it? It does appear to be the same underlying issue I believe. My workaround for bug 1802889 has just landed to autoland.

I wrote up bug 1808903 to back out our workaround after the sync team resolves bug 1808651.

Comment 7

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Going to go ahead and mark this as Fixed by my patch from bug 1802889. Still need QA to verify this in Nightly though.

Comment 8

[Mark Hammond (PTO; back Oct-3) [:markh] [:mhammond]]

Sorry for the delay Kelly and thanks for opening that other "backout" bug - I think that's all perfect.