1802902 - [HCM] The "Tab Pickup" and "Recently closed" titles show a grey background with High Contrast enabled on Mac and Linux

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Rares Doghi, Desktop QA]

Found in

• 109.0a1 (2022-11-28)

Affected versions

• Firefox Nightly 109.0a1 (2022-11-28)
• Beta 108.0b6
• Release 107.0

Preconditions

• Enable High Contrast on both Linux and MacOS

Affected platforms

• Ubuntu, Mac

Steps to reproduce

1. Reach the Fx View page.

Expected result

• The "Tab Pickup" and "Recently closed" titles and description should not show a dark background in High Contrast.

Actual result

• The "Tab Pickup" and "Recently closed" titles and descriptions show a grey background color in High Contrast.
• Please note that on Windows this issue does not occur.

Regression range
This issue is not a regression.

Comment 1

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Looks like this was regressed as part of the updates in bug 1786397. Based on Anna's comment, it looks like the expected styles here would be to use WindowText for color and to not set background-color.

Comment 2

[❌OOO Until Oct 7 ❌ Kelly Cochrane [:kcochrane]]

Attachment: Bug 1802902 - Correct HCM text/background colors for Tab Pickup and Recently Closed headers of Fx View r=sfoster

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786397

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7901807ba0d
Correct HCM text/background colors for Tab Pickup and Recently Closed headers of Fx View r=sfoster,ayeddi

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c7901807ba0d

Comment 6

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 110.0a1 (2022-12-18).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Is this something we wanted to nominate for Beta uplift? Please do so if yes since Kelly is OOO.

Comment 8

[Anna Yeddi [:ayeddi]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)

Is this something we wanted to nominate for Beta uplift? Please do so if yes since Kelly is OOO.
That would be a good thing to do. I'll write the nomination up

Comment 9

[Anna Yeddi [:ayeddi]]

Comment on attachment 9308325 [details]
Bug 1802902 - Correct HCM text/background colors for Tab Pickup and Recently Closed headers of Fx View r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Users of High Contrast Mode on macOS and Linux may find it difficult to read the heading text and it would not look consistent with another element's while on HCM. The goal of HCM (though named High contrast mode) is to provide a user interface which respects customisations users have made in their system preferences. Users may customise their palette to adapt their system for photosensitivity, colorblindness, or other vision needs that are not strictly helped by high contrast.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: STR are listed in the bug. The OS-provided HCM can be activated via:

• MacOS: System Preferences > Accessibility > Display > Increase Contrast
• Linux: Settings > Themes > High Contrast

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Uplifting poses a Low risk, because the change is minor, affects only one CSS file, for one page (Fx View), only one line of code is changed that affects HCM users alone
• String changes made/needed: none
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9308325 [details]
Bug 1802902 - Correct HCM text/background colors for Tab Pickup and Recently Closed headers of Fx View r=sfoster

Approved for 109.0b5, thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fcda48e5b20e

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta build 109.0b5.

Comment 13

[Rares Doghi, Desktop QA]

Updating the Main Status flag.