1803107 - When pinning a normal tile, the pinned tile next to it switches places and became unpinned, while a Sponsored tile via Pocket is displayed

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: strange behavior while dragging normal tiles when Pocket tiles are displayed.mp4

[Notes]:

• Another strange behavior can be observed if you drag and drop a tile from the left to right, an empty tile is created. If repeating this multiple times, you will notice that a new row is displayed, with multiple empty tiles. Not sure if this happens because of this issue or if it's a new one.

[Affected versions]:

• Nightly 109.01a
• Beta 108.0b7

[Affected Platforms]:

• Mac 12.4
• Windows 10 x64
• Linux Mint 20

[Prerequisites]:

• Have the Sponsored tiles via Pocket configured and displayed.

[Steps to reproduce]:

1. Open the Nightly browser with the profile from the prerequisites.
2. Pin the 3rd normal tile and observe the behavior.
3. Pin again the 3rd tile and observe the behavior.

[Expected result]:
Step 2: The 3rd tile is pinned and remains in the same position.
Step 3: The tile is already pinned.

[Actual result]:
Step 2: The 3rd tile jumps to the next position after it's pinned.
Step 3: The new 3rd tile switches position with the 4th pinned tile, and the initial 4th pinned tile became unpinned in position 3rd.

[Notes]:

• This behavior is not reproducible if there are Sponsored tiles via Contile displayed.
• The issue is not reproducible if there are NO sponsored tiles displayed.
• Attached is a screen recording of the issue.

Comment 1

[Scott [:thecount] Downe]

Attachment: Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile.

Comment 2

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/19a08ca78a7f

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:thecount, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox108 to wontfix.

For more information, please visit auto_nag documentation.

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 109.0a1 build (Build ID: 20221201161829) on Windows 10 x64, macOS 12.4 and Linux Mint 20.

• The described issue is no longer reproducible.

However, I have found two other storage behaviors.

1. I think that one of the normal tiles is hidden under the Sponsored tile via Pocket. Because of this, if you pin the tile from positions 1 and 3 when you drag the first one over the 3rd one, the hidden tile is displayed, and the moved one disappears.
2. If you have all the tiles pinned then the Sponsored tile via Pocket is displayed, glitches are displayed when dragging from right to left a pinned tile over the 3rd one. Here is a screen recording with the issue: Link.

Unfortunately, I don't have enough time to log these behaviors, but I will try Monday to log a separate issue for them. Also, I'm marking this issue as verified - fixed since the initial issue is no longer reproducible and we will track the behavior described in separate bugs.