1803338 - Incorrect Usage of rmtree in packageit.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Redfire]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

1. Clone https://hg.mozilla.org/mozilla-build
2. Start the Mozilla Build Shell (start-shell.bat)
3. Run ./packageit.py

Actual results:

The script errored with:

Traceback (most recent call last):
  File "C:\mozilla-source\mozilla-build\packageit.py", line 216, in <module>
    shutil.rmtree(locale_path)
NameError: name 'shutil' is not defined

Expected results:

packageit.py should not have errored and should have run till completion.

shutil.rmtree should be replaced with rmtree on the following line https://hg.mozilla.org/mozilla-build/file/tip/packageit.py#l216

Comment 1

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1803338 - Correctly call `rmtree` when removing the `locale` dir r?#build

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-build/rev/2c18776dd6ff
Correctly call rmtree when removing the locale dir r=firefox-build-system-reviewers,nalexander