1803363 - [DNR] Add some telemetry probes for the rule store

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1745763 we are going to consider adding some telemetry probes related to the DNR rule store, so that we can gather some data about the amount of data stored, incidence of errors of loading and saving DNR rules data to disk, time to load the rules on extension startup and actual number of rules loaded from disk.

The telemetry data to be collected is meant to be used:

• as a base line to assess changes (as an example performance improvements or bumps to the rule limits being considered)
• assess incidence of certain issue (e.g. errors on saving and load the rules from disk)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1803363_request.md

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Record telemetry probes on ExtensionDNRStore validating rules and reading/writing startup cache data. r?robwu!

Depends on D162402

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Record telemetry probes on ExtensionDNR rules validation. r?robwu!

Depends on D174022

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Record labeled counters telemetry probes on startup cache entries hit and miss. r?robwu!

Depends on D174023

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Record timing distribution telemetry probe time to completes DNR rules evaluation. r?robwu!

Depends on D174024

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Record metrics related to the amount of DNR rules enabled during DNR rule evaluation. r?robwu!

Depends on D174025

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Mirror ExtensionDNRStore glean distribution metrics into unified telemetry histograms. r?robwu!

Depends on D174026

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Mirror ExtensionDNRStore glean labeled counter metrics into unified telemetry scalars. r?robwu!

Depends on D174027

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Mirror ExtensionDNR glean distribution metrics into unified telemetry histograms. r?robwu!

Depends on D174028

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Mirror ExtensionDNR glean quantity metrics into unified telemetry scalars. r?robwu!

Depends on D174029

Comment 11

[Chris H-C :chutten]

Comment on attachment 9325702 [details]
bug1803363_request.md

PRELIMINARY NOTES:
Have you head of ./mach data-review? It can help you write your Data Review Requests. More info here and ./mach help data-review.

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in six months.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Applied some more small improvements evaluatRulesCountMax test coverage. r?robwu!

Depends on D174030

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1803363 - Fix dynamic rules not converted back into Rule class instances when loaded back from DNR store file. r?robwu!

Depends on D174640

Comment 14

[Phabricator Automation]

Comment on attachment 9326904 [details]
Bug 1803363 - Fix dynamic rules not converted back into Rule class instances when loaded back from DNR store file. r?robwu!

Revision D174641 was moved to bug 1826383. Setting attachment 9326904 [details] to obsolete.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bec053ab0b67
Record telemetry probes on ExtensionDNRStore validating rules and reading/writing startup cache data. r=robwu
https://hg.mozilla.org/integration/autoland/rev/58ed4a29bbf9
Record labeled counters telemetry probes on startup cache entries hit and miss. r=robwu
https://hg.mozilla.org/integration/autoland/rev/89526c8b5f1c
Record timing distribution telemetry probe time to completes DNR rules evaluation. r=robwu
https://hg.mozilla.org/integration/autoland/rev/1a398e99af57
Record metrics related to the amount of DNR rules enabled during DNR rule evaluation. r=robwu
https://hg.mozilla.org/integration/autoland/rev/6abe9eb50d9d
Mirror ExtensionDNRStore glean distribution metrics into unified telemetry histograms. r=robwu
https://hg.mozilla.org/integration/autoland/rev/55631b70780c
Mirror ExtensionDNRStore glean labeled counter metrics into unified telemetry scalars. r=robwu
https://hg.mozilla.org/integration/autoland/rev/87e9ee1bf84d
Mirror ExtensionDNR glean distribution metrics into unified telemetry histograms. r=robwu
https://hg.mozilla.org/integration/autoland/rev/1902bd8f971d
Mirror ExtensionDNR glean quantity metrics into unified telemetry scalars. r=robwu
https://hg.mozilla.org/integration/autoland/rev/b14406c4054c
Applied some more small improvements evaluatRulesCountMax test coverage. r=robwu

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bec053ab0b67
https://hg.mozilla.org/mozilla-central/rev/58ed4a29bbf9
https://hg.mozilla.org/mozilla-central/rev/89526c8b5f1c
https://hg.mozilla.org/mozilla-central/rev/1a398e99af57
https://hg.mozilla.org/mozilla-central/rev/6abe9eb50d9d
https://hg.mozilla.org/mozilla-central/rev/55631b70780c
https://hg.mozilla.org/mozilla-central/rev/87e9ee1bf84d
https://hg.mozilla.org/mozilla-central/rev/1902bd8f971d
https://hg.mozilla.org/mozilla-central/rev/b14406c4054c