Last Comment Bug 180346 - Impl new interfaces for external spell checkers
: Impl new interfaces for external spell checkers
Product: Core
Classification: Components
Component: Spelling checker (show other bugs)
: Trunk
: All All
-- normal with 7 votes (vote)
: mozilla1.3beta
Assigned To: Nobody; OK to take it and work on it
: Jet Villegas (:jet)
: 58615 (view as bug list)
Depends on:
Blocks: 67208 69687 129704 spellchecker 119232
  Show dependency treegraph
Reported: 2002-11-15 10:49 PST by rods (gone)
Modified: 2014-04-26 02:26 PDT (History)
34 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

New SpellCheck Interfaces (9.83 KB, patch)
2002-11-16 15:26 PST, rods (gone)
no flags Details | Diff | Splinter Review
patch (interfaces and new glue code) (34.82 KB, patch)
2002-11-16 15:54 PST, rods (gone)
no flags Details | Diff | Splinter Review
SpellCheck Diagram (4.48 KB, image/gif)
2002-11-16 16:17 PST, rods (gone)
no flags Details
new spellcheck directory in extensions (272.20 KB, patch)
2002-12-13 12:50 PST, rods (gone)
no flags Details | Diff | Splinter Review
Changes to editor directory (61.61 KB, patch)
2002-12-13 12:51 PST, rods (gone)
no flags Details | Diff | Splinter Review
debug pref panel changes (2.64 KB, patch)
2002-12-13 12:55 PST, rods (gone)
no flags Details | Diff | Splinter Review
patch (116.02 KB, patch)
2002-12-23 07:34 PST, rods (gone)
no flags Details | Diff | Splinter Review
patch for config files (2.23 KB, patch)
2002-12-23 14:02 PST, rods (gone)
no flags Details | Diff | Splinter Review

Description User image rods (gone) 2002-11-15 10:49:51 PST
Comment 1 User image Christian :Biesinger (don't email me, ping me on IRC) 2002-11-15 13:52:55 PST
Can you explain what this is about?
Comment 2 User image rods (gone) 2002-11-15 14:07:34 PST
I have a new set of interfaces based on David Einsteins work that will enable
external spell checkers to work within  Mozilla. The default spell checker will
still be our SC for Netscape. But David said he would port his MySpell over to
work with Mozilla so then Mozilla will have a spell checker.
Comment 3 User image Chan Min Wai 2002-11-16 08:41:51 PST
oh so what did you need on that.
Comment 4 User image rods (gone) 2002-11-16 15:26:22 PST
Created attachment 106523 [details] [diff] [review]
New SpellCheck Interfaces

These are the new interfaces for enabling Mozilla to work with external
Comment 5 User image rods (gone) 2002-11-16 15:54:30 PST
Created attachment 106525 [details] [diff] [review]
patch (interfaces and new glue code)

Here are the interfaces with what I hope is the correct MPL and the new glue
code for mozilla.
Comment 6 User image rods (gone) 2002-11-16 16:17:45 PST
Created attachment 106526 [details]
SpellCheck Diagram

Diagram of the object hierarchy
Comment 7 User image Aleksey Nogin 2002-11-20 18:09:14 PST
Is bug 58615 a dup of this one? Bug 56301 comment #234 seems to imply that it is.
Comment 8 User image rods (gone) 2002-11-21 05:53:19 PST
*** Bug 58615 has been marked as a duplicate of this bug. ***
Comment 9 User image Greg K. 2002-11-21 09:54:52 PST
Is this relevant to bug 86886?
Comment 10 User image rods (gone) 2002-11-21 10:28:53 PST
Greg, what this means is that someone can now provide and impl of the apple
spellcheck to these new interfaces.
Comment 11 User image Greg K. 2002-11-21 11:21:07 PST
Thanks, rods. Sounds like this should be All/All.
Comment 12 User image rods (gone) 2002-12-03 14:26:47 PST
Comment on attachment 106525 [details] [diff] [review]
patch (interfaces and new glue code)

The interfaces are fine, I am obsoleting this because I have made some
significant changes to some of the glue code and I don't want this patch to be
reviewed. Plus, I think I will be moving this to the "extensions" directory.
Comment 13 User image rods (gone) 2002-12-13 12:50:55 PST
Created attachment 109251 [details] [diff] [review]
new spellcheck directory in extensions
Comment 14 User image rods (gone) 2002-12-13 12:51:55 PST
Created attachment 109252 [details] [diff] [review]
Changes to editor directory
Comment 15 User image rods (gone) 2002-12-13 12:55:48 PST
Created attachment 109254 [details] [diff] [review]
debug pref panel changes
Comment 16 User image rods (gone) 2002-12-16 08:20:19 PST
Comment 17 User image rods (gone) 2002-12-23 07:29:30 PST
taking back
Comment 18 User image rods (gone) 2002-12-23 07:34:36 PST
Created attachment 110000 [details] [diff] [review]

This patch contains only the changes for splitting the glue code apart and
being able to spellcheck an arbitrary selection
Comment 19 User image Simon Fraser 2002-12-23 10:52:41 PST
+#ifdef XP_MAC
+#define IS_NBSP_CHAR(c) (((unsigned char)0xca)==(c))
+#define IS_NBSP_CHAR(c) (((unsigned char)0xa0)==(c))

That might need to be 
#if defined(XP_MAC) || defined(XP_MACOSX)
Comment 20 User image rods (gone) 2002-12-23 14:02:20 PST
Created attachment 110025 [details] [diff] [review]
patch for config files

These files will put the mozilla/extensions/spellcheck into the build
Comment 21 User image 2003-02-13 13:20:09 PST

what is the status on this bug? Can we start porting mozdev's spell checker to
the new glue code?
Comment 22 User image Daniel Jensen 2003-03-19 12:38:41 PST
Any chance of this going in during the 1.4 cycle?
Comment 23 User image Simon Spiegel 2003-04-04 06:45:07 PST
Has the now Mozilla roadmap any influence on this bug? Will 
Minotaur/Thunderbird/Moz1.5 ship with a spellchecker? AFAIK additions/plugins 
should be easier to handle with the new approach. Will the spellchecker remain a 
mozdev addon, or will it once be part of the distribution?
Comment 24 User image Aleksey Nogin 2003-08-28 14:33:19 PDT
Now that mozdev spellchecker is in the tree, is this bug still relevant?
Comment 25 User image :Gavin Sharp [email:] 2012-02-14 00:26:24 PST
I'm pretty sure this is no longer valid.

Note You need to log in before you can comment on or make changes to this bug.