180374 - switch from ftp to http in config.ini

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[(not reading, please use [e-mail] instead)]

mac stub installer (11-15-2002) fails

if you are behind the firewall, see
http://bugscape.nscp.aoltw.net/show_bug.cgi?id=21411

note, the full installer works.

Comment 1

[J.J. Enser]

actually, bugscape bug 21411 is different (chrome issue, not installer related).

the problem here is that the install wizard starts downloading the selected
components but "pauses" many times. Clicking the "resume" several times
eventually causes the fatal error messages "Installation failed due to error -805".

All this happens apparently while downloading xpcom.xpi

A full installer (with a local xpcom.xpi) works fine.

Comment 2

[Syd Logan]

Internal netscape installer works fine, only difference is going to be the xpis
or the ftp server (we don't use ftp.mozilla.org for netscape nightlies). Are the
ftp server logs showing any problems? pause/Resume like behaviour like this
makes me think there might be a problem.

Comment 3

[J.J. Enser]

I'm actually replacing xpcom.xpi on ftp just to check if the installer I already
have on my machine works better afterwards

Comment 4

[Syd Logan]

It's not that, we are still trying to just download XPIs.

-805 translates to "FTP command error" (we don't display error text for fear it
will confuse people :-)

Comment 5

[J.J. Enser]

Dawn, Asa, Syd says error -805 we're seeing mean a possible network/ftp problem
on ftp.moz.org.
replacing xpcom.xpi on f.m.o didn't help.

Comment 6

[Dawn Endico]

darin, any ideas? did anything change in networking recently that would make ftp
fail? maybe in nspr? did the nspr tag change recently?

Comment 7

[Darin Fisher]

necko is not used by the stub installer.  it uses its own specific FTP
implementation.

Comment 8

[J.J. Enser]

Seth, can you try again your mac installer (no need to re-download it, just
re-run it)
today's mozilla stub installer works for me now.

After replacing xpcom.xpi in the mac-xpi dir on ftp.mozilla.org, the problem
seemed to go away. download and installation now complete. But Syd says error
-805 cannot happen due to a corrupted file but is due to a network/server problem...

Reassigning to asa.

note that I left the xpcom.xpi file that was originally uploaded and was
exposing (if not causing) the problem:
ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-11-15-09-trunk/mac-xpi/xpcom-corrupt.xpi

Comment 9

[grylchan]

Yup JJ, you are right. using teh same stub build, it NOW works.
No error, no  pausing..

Weird.

Comment 10

[Dawn Endico]

at syd's request i put the original xpcom.xpi back in place.
we now have:


ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-11-15-09-trunk/mac-xpi/xpcom.xpi
copy of xpcom-corrupt.xpi

ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-11-15-09-trunk/mac-xpi/xpcom-corrupt.xpi
file from original morning build

ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-11-15-09-trunk/mac-xpi/xpcom.xpi.good
test file that jj uploaded at 16:52

Comment 11

[Syd Logan]

again, i don't think the XPI is the issue. in fact, I was able to fail in the
same way in browser.xpi. what does seem clear is that the http protocol behaves
much better for some reason. 

Comment 12

[J.J. Enser]

Now that we're pretty sure it's some kind of network or server problem, I'm
downgrading this bug to critical so that it doesn't keep the tree closed.

Should require more investigation on the server side as to what causes these
glitches.
if we conclude that http is the preferred protocol for nightlies (it is already
for public releases) then I'll submit the appropriate patch here.

Comment 13

[Christopher Blizzard (:blizzard)]

We should just use HTTP.

Comment 14

[(not reading, please use [e-mail] instead)]

if we use http in official builds, let's switch to that for nightly.

syd, ssu, dveditz, any reason not to switch from ftp to http?

re-assign to jj

Comment 15

[Daniel Veditz [:dveditz]]

These sound exactly like the symptoms that caused us to switch releases from FTP
to HTTP, I don't know why we wouldn't have switched nightlies at the same time
as releases since they use the same servers.

Comment 16

[J.J. Enser]

There must have been a reason why we kept using ftp for nithglies, and add the
extra step to switch to http for public releases ... but I don't know what it is.
cc'ing more installer people, who might actually remember :-)

After verification, it seems lile both Windows and Linux use http in nightly
builds. Patch coming up to use http in mac builds as well.

Comment 17

[J.J. Enser]

Attachment: patch for mac nightly builds (switch to http protocol for xpi download)

Comment 18

[Jon Granrose]

I know of no reason not to use http: for the mozilla stub installers.  We should
make sure to change all platforms, not just mac.

Comment 19

[J.J. Enser]

I already checked Windows and Linux automations and they already use http.

r/sr anyone?

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 106705 [details] [diff] [review]
patch for mac nightly builds (switch to http protocol for xpi download)

sr=dveditz

Comment 21

[Syd Logan]

Comment on attachment 106705 [details] [diff] [review]
patch for mac nightly builds (switch to http protocol for xpi download)

r=syd

Comment 22

[J.J. Enser]

fixed. patch checked in on the trunk.
I think this is safe enough to go on the 1.2 branch. Asa, can I just update the
target milestone and add the mozilla1.2 keyword for it to show on the 1.2 radar?

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 106705 [details] [diff] [review]
patch for mac nightly builds (switch to http protocol for xpi download)

jj wants this for 1.2 branch.

Comment 24

[Asa Dotzler [:asa]]

Comment on attachment 106705 [details] [diff] [review]
patch for mac nightly builds (switch to http protocol for xpi download)

a=asa for checkin to 1.2 branch

Comment 25

[J.J. Enser]

checked in on the 1.2 branch

Comment 26

[K'Trina Medina]

Verified