1803986 - Remove last remaining nsIScriptableUnicodeConverter usages across the Thunderbird codebase

Status: ASSIGNED

(Thunderbird :: General, task)

Description

[Geoff Lankow (:darktrojan)]

+++ This bug was initially created as a clone of Bug 1762335 +++

There's one last use of nsIScriptableUnicodeConverter, in EnigmailData. Most of the callers use UTF-8 as the charset, and can probably be replaced easily enough, but some don't. I don't know of another way to convert from an arbitrary charset at this point, so I'm leaving the function behind.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1803986 - Remove nsIScriptableUnicodeConverter usage from OpenPGP code. Part 1: UTF-8 to bytestring cases. r=john.bieling

Use standard means to get bytestring from utf-8 data.

var {EnigmailData} = ChromeUtils.import("chrome://openpgp/content/modules/data.jsm");
var {MailStringUtils} = ChromeUtils.import("resource:///modules/MailStringUtils.jsm");
var text = "blä";
var A = EnigmailData.convertFromUnicode(text, "utf-8")
var B = MailStringUtils.stringToByteString(text);
A + " vs " + B;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/234c7fb296c4
Remove nsIScriptableUnicodeConverter usage from OpenPGP code. Part 1: UTF-8 to bytestring cases. r=john.bieling

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1803986 - Part 2: convert unconventional string conversions. r=kaie

Remove some non-standard string conversions and unneeded conversion methods.

var {EnigmailData} = ChromeUtils.import("chrome://openpgp/content/modules/data.jsm");
var {MailStringUtils} = ChromeUtils.import("resource:///modules/MailStringUtils.jsm");
var text = "blä";
var A = EnigmailData.getUnicodeData(text)
var B = new TextDecoder("ISO-8859-1").decode(MailStringUtils.byteStringToUint8Array(text));
A + " vs " + B;

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1803986 - Part 3: Remove EnigmailData.convertToUnicode usages. r=kaie,#thunderbird-reviewers

Depends on D192368

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/228762f3ba68
Part 2: convert unconventional string conversions. r=kaie
https://hg.mozilla.org/comm-central/rev/ea487393c15f
Part 3: Remove EnigmailData.convertToUnicode usages. r=kaie

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: Bug 1803986 - Part 4 - remove some OpenPGP usage of homegrown mime parsing. r=kaie

Don't needlessly modify the decrypted data and try to de-code/re-code it later.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ea5aa9daf42d
Part 4 - remove some OpenPGP usage of homegrown mime parsing. r=kaie