Enable interaction measurements in nightly only
Categories
(Toolkit :: Places, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: mossop, Assigned: mossop)
References
Details
Attachments
(1 file)
Turn on interaction measurements in nightly only (browser.places.interactions.enabled) for Firefox 110
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Comment 3•3 years ago
|
||
Backed out for causing mochitest failures in browser/base/content/test/performance/browser_startup_content.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/ea43e6f742608b63b5ef8ba730c6e0108b55e168
INFO - Buffered messages finished
[task 2022-12-20T09:34:33.507Z] 09:34:33 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_content.js | should have no unexpected modules loaded on content process startup - Got 2, expected +0
[task 2022-12-20T09:34:33.507Z] 09:34:33 INFO - Stack trace:
|
||
Comment 4•3 years ago
|
||
This failure https://treeherder.mozilla.org/logviewer?job_id=400205710&repo=autoland has also turned perma from the above changes, TH link.
|
|
Assignee | |
Comment 5•3 years ago
|
||
(In reply to Sandor Molnar from comment #3)
Backed out for causing mochitest failures in browser/base/content/test/performance/browser_startup_content.js
(In reply to Cosmin Sabou [:CosminS] from comment #4)
This failure https://treeherder.mozilla.org/logviewer?job_id=400205710&repo=autoland has also turned perma from the above changes, TH link.
Mark is there any chance you have a few moments to look at these? They look fairly straightforward. It would be really good to get this landed but unfortunately it looks like I'm going to be out sick the rest of the week.
|
||
Comment 6•3 years ago
|
||
I've hopefully fixed the test issues. I had a deep look at seeing if we can avoid loading the interactions modules in the content process early on, but I can't see a way to do that - the test is loading an empty page via http protocol, and that's a case where we do need the interactions modules loaded to potentially process what's happening. Hence, I don't think there's a way around it.
The other case was to handle browser being closed really quickly before they open.
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 9•3 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #6)
I've hopefully fixed the test issues. I had a deep look at seeing if we can avoid loading the interactions modules in the content process early on, but I can't see a way to do that - the test is loading an empty page via http protocol, and that's a case where we do need the interactions modules loaded to potentially process what's happening. Hence, I don't think there's a way around it.
The other case was to handle browser being closed really quickly before they open.
Thanks Mark!
Description
•