1807647 - 3.1 - 2.17% Base Content JS / Base Content Explicit + 3 more (Linux, OSX, Windows) regression on Wed December 21 2022

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Acasandrei Beatrice (needinfo me)]

Perfherder has detected a awsy performance regression from push 70a7556819cb195fcb0ddf98cdaaee56dfe523f4. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	Base Content JS	windows10-64-2004-shippable-qr	fission	1,607,456.00 -> 1,657,360.00
3%	Base Content JS	linux1804-64-shippable-qr	fission	1,608,891.33 -> 1,650,827.33
3%	Base Content JS	windows10-64-2004-shippable-qr	fission	1,615,407.33 -> 1,657,360.00
3%	Base Content JS	macosx1015-64-shippable-qr	fission	1,608,956.00 -> 1,650,536.00
2%	Base Content Explicit	linux1804-64-shippable-qr	fission	7,657,114.67 -> 7,823,002.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1804227

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1807647: Don't load the interactions blocking in the content process. r=Standard8!

We already load the blocklist in the parent process and verify new urls against
it before storing them so there isn't actually a need to load the blocklist
in every content process as well.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eedb2bc439a5
Don't load the interactions blocking in the content process. r=Standard8

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/eedb2bc439a5

Comment 5

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eedb2bc439a5
Don't load the interactions blocking in the content process. r=Standard8

== Change summary for alert #36710 (as of Tue, 10 Jan 2023 07:53:33 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	Base Content JS	linux1804-64-shippable-qr	fission	1,644,056.00 -> 1,618,354.67
2%	Base Content JS	windows10-64-2004-shippable-qr	fission	1,650,680.00 -> 1,625,976.67
1%	Base Content JS	windows10-64-2004-shippable-qr	fission	1,650,712.00 -> 1,626,080.00
1%	Base Content JS	macosx1015-64-shippable-qr	fission	1,644,465.33 -> 1,622,168.00

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36710