1804258 - New SearchTermSuggestionsProvider for awesomebar suggestions

Status: RESOLVED FIXED

(Firefox for Android :: Search, enhancement)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: FenixMockup.png

Tracking https://mozilla-hub.atlassian.net/browse/FNXV2-22037

The “Search History (for that search engine)” provider shown here [1] - should:

• identify the search term used for searches
• remember all search terms mapped to each search engine used
• present up to 2 suggestions for past search terms for the currently selected search engine.

** This already works on desktop.

[1] https://www.figma.com/file/epu0Sj6mCPk7K282sNpHgI/Site?node-id=3850%3A59494&t=HLP0RsRZsF6rbjWE-0

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1804258 - New SearchTermSuggestionsProvider (#263)

Comment 2

[BMO Automation]

Comment on attachment 9306885 [details] [review]
[mozilla-mobile/firefox-android] Bug 1804258 - New SearchTermSuggestionsProvider (#263)

GitHub pull request attachment was moved to bug 1759890. Setting attachment 9306885 [details] [review] to obsolete.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1e97af3d238
Prevent overlapping of cancel requests for history reads
https://hg.mozilla.org/integration/autoland/rev/f055d2f3dab2
New SearchTermSuggestionsProvider
https://hg.mozilla.org/integration/autoland/rev/bdb164873ec3
Emit a telemetry fact when a search term suggestion is clicked
https://hg.mozilla.org/integration/autoland/rev/8b5a05a8b3a0
Show search terms suggestions from history above search suggestions
https://hg.mozilla.org/integration/autoland/rev/e7368ca852c4
Update buildconfig.yml with upstream dependencies

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

I believe this is already fixed in https://github.com/mozilla-mobile/firefox-android/pull/263. Marking as WORKSFORME

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: GitHub Pull Request

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: GitHub Pull Request