1804375 - Re-enable some clang warnings that no longer need to be disabled for gtest or Skia

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Chris Peterson [:cpeterson]]

Bug 1324242 disabled clang's -Wnull-dereference warnings in gtest code, but this warning can be re-enabled because the current version of gtest doesn't trigger these warnings.

Bug 1236323 disabled clang's -Wimplicit-fallthrough warnings from some Skia headers, but this warning can be re-enabled because the current version of Skia doesn't trigger these warnings.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1804375 - Re-enable clang -Wnull-dereference warnings in gtest. r?#firefox-build-system-reviewers

Bug 1324242 disabled clang's -Wnull-dereference warnings in gtest code, but this warning can be re-enabled because the current version of gtest doesn't trigger these warnings.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1804375 - Re-enable clang's -Wimplicit-fallthrough warnings in gfx code including Skia headers. r?#gfx-reviewers

Bug 1236323 disabled clang's -Wimplicit-fallthrough warnings from some Skia headers, but this warning can be re-enabled because the current version of Skia doesn't trigger these warnings.

Depends on D164027

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b90142a28026
Re-enable clang -Wnull-dereference warnings in gtest. r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/3c5cbae5db36
Re-enable clang's -Wimplicit-fallthrough warnings in gfx code including Skia headers. r=gfx-reviewers,lsalzman

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b90142a28026
https://hg.mozilla.org/mozilla-central/rev/3c5cbae5db36