Closed Bug 1804490 Opened 2 years ago Closed 2 years ago

PDF.js annotation message appears in Firefox View

Categories

(Firefox :: Messaging System, defect, P1)

Firefox 109
defect

Tracking

()

VERIFIED FIXED
109 Branch
Iteration:
109.2 - Nov 28 - Dec 9
Tracking Status
firefox109 --- verified
firefox110 --- verified

People

(Reporter: mviar, Assigned: mviar)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When the browser.pdfjs.feature-tour has a screen value equal to one of the screen ids in a PDF.js message, the callout unexpectedly shows in Firefox View instead of that feature's tour.

To resolve this issue, we can add additional targeting to the PDF.js messages that restrict them to showing only when the source ends in .pdf.

Depends on: 1803654
Depends on: 1803660
Attachment #9307170 - Attachment description: WIP: Bug 1804490 - Update PDF.js callout messages' targeting to only show on PDF documents → Bug 1804490 - Update PDF.js callout messages' targeting to only show on PDF documents

S1 severity is defined as (Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available. Is that correct for this bug?
https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity

Flags: needinfo?(mviar)

Thanks for flagging that, :RyanVM - meant to make this S2 (definitely not catastrophic!). Could be an S3, but there's no workaround to prevent the issue.

Flags: needinfo?(mviar)
Severity: S1 → S2
Priority: P1 → --
Priority: -- → P1
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91d43802acb7 Update PDF.js callout messages' targeting to only show on PDF documents r=jprickett
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

I‘ve verified this issue using the latest Firefox Nightly 110.0a1 (Build ID: 20221219162526) and Firefox Beta 109.0b4 (Build ID: 20221218190303) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

  • The PDF Feature callout messages are not displayed on the Firefox View page.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: