Closed Bug 1804537 Opened 2 years ago Closed 1 year ago

SeaMonkey switch to fullscreen does not work.

Categories

(SeaMonkey :: OS Integration, defect)

SeaMonkey 2.53 Branch
Unspecified
macOS
defect

Tracking

(seamonkey2.53+ fixed)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.15)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1797696 +++

Switching to fullscreen recent macOS releases does not work. You need to close SeaMonkey and restart it. Brian did a set of patches for Waterfox which need to be be taken to our tree.

Fullscreen patch from Brian. r/a=me

Test with 2.53.16b1 pre and for our release branch only.

Attachment #9307161 - Flags: review+
Attachment #9307161 - Flags: approval-comm-release+
Attachment #9307161 - Flags: approval-comm-esr60+

Additional patch for possible transdparent menu problem. SeaMonkey seems not to be affected initially but this might change with later backports.

Test with 2.53.16b1 pre and for our release branch only.

Attachment #9307162 - Flags: review+
Attachment #9307162 - Flags: approval-comm-release+
Attachment #9307162 - Flags: approval-comm-esr60+

Can confirm that on macOS Monterey running SeaMonkey 2.53.14 or prior, full screen sometimes worked. When full screen could enable, the top-most window bar with close-minimize-expand, red-yellow-green buttons sometimes disappeared. Only way to turn off full screen was using macOS Finder's Spaces—aka Mission Control—to option+click a desktop as "closed." Have not yet tested SeaMonkey full screen on macOS Ventura because I use its new Stage Manager and have already seen odd behavior with side-loaded apps, but I am eager to at least try Stage Manager with 2.53.15 Beta 1. Is there an ETA on a stable/full 2.53.15 release, out of Beta 1? Or do you need more feedback on Beta 1 still?

Flags: needinfo?(frgrahl)

We are waiting for a new code signing cert for Windows. When we get it, which I assume is this week, we will do the final 2.53.15 build. It will have a few more fixes over 2.53.15 beta but nothing dramatic. 2.53.14 or earlier will not work on Ventura. You can switch to the beta and then move to the final later if you need Ventura support. There is still a minor glitch with restore from full screen but this can be fixed with justa a manual Window resize.

Flags: needinfo?(frgrahl)
Comment on attachment 9307162 [details] [diff] [review]
1804537-macostransparent-25315.patch

>+++ b/widget/cocoa/nsCocoaWindow.mm
>@@ -488,16 +488,21 @@ nsresult nsCocoaWindow::CreateNativeWind
>   mWindow = [[windowClass alloc] initWithContentRect:contentRect styleMask:features 
>                                  backing:NSBackingStoreBuffered defer:YES];
> 
>   // Make sure that window titles don't leak to disk in private browsing mode
>   // due to macOS' resume feature.
>   [mWindow setRestorable:NO];
>   [mWindow disableSnapshotRestoration];
> 
>+  // Make sure that window titles don't leak to disk in private browsing mode
>+  // due to macOS' resume feature.
>+  [mWindow setRestorable:NO];
>+  [mWindow disableSnapshotRestoration];
>+
Isn't this a repeat of the block above?
Flags: needinfo?(frgrahl)

(In reply to Frank-Rainer Grahl (:frg) from comment #4)

We are waiting for a new code signing cert for Windows. When we get it, which I assume is this week, we will do the final 2.53.15 build. It will have a few more fixes over 2.53.15 beta but nothing dramatic. 2.53.14 or earlier will not work on Ventura. You can switch to the beta and then move to the final later if you need Ventura support. There is still a minor glitch with restore from full screen but this can be fixed with justa a manual Window resize.

Thanks for all the work you and your team put in, the Beta 1 version worked great and have been using the full release as of this morning. We appreciate your time and efforts!

SeaMonkey release branch only

Isn't this a repeat of the block above?
yes fixed in 2.53.16b1 pre already

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/a5596714543be74634b7cf7df0f02cb52393ff2f
Disable wantsFloatingTitlebar code on Big Sur 11.0 and higher. r=frg a=frg

https://gitlab.com/seamonkey-project/seamonkey-2.53-mozilla/-/commit/60157c7d3c86e99ea22ccb64b78633d861afbe91
Fix transparent windows on Ventura. r=frg a=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Flags: needinfo?(frgrahl)
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.53
Version: Trunk → SeaMonkey 2.53 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: