Closed Bug 18046 Opened 20 years ago Closed 20 years ago

[DOGFOOD] nsISelectionController needs IDL and implementation finished


(Core :: DOM: Selection, defect, P3, blocker)






(Reporter: mjudge, Assigned: mjudge)



(Whiteboard: [PDT+] [by 12/15])


(2 files)

nsPresShell implements this interface.  interface now just a header and not IDL.
when implementation is actually progressing we will add IDL to generate the
nsISelectionController.h file.
Blocks: 18033
Target Milestone: M12
I'm putting this on the M12 list -- adjust it if you think it needs to be
somewhere else Mike.
Whiteboard: [CODE cleanup]
Target Milestone: M12 → M14
setting this out to M14 -- cleanup time
Whiteboard: [CODE cleanup]
Beth, I'm removing the [CODE cleanup] designation you put on the status
whiteboard; I have a PDT+ bug which depends on this one, so it's more than just
a cleanup issue.
Target Milestone: M14 → M12
Moving back to M12.
Whiteboard: [18033 PDT+ dependent]
no problem -- so I won't do it again -- I'm putting in a PDT entry in whiteboard
-- sorry about that, next time I'll look at the dependency bugs.
Blocks: 12658
linking to PDT+ tracking bug 12658
Summary: nsISelectionController needs IDL and implementation finished → [DOGFOOD] nsISelectionController needs IDL and implementation finished
there is a PDT+ bug that is dependent on this getting fixed, putting on the
Blocks: 18471
Whiteboard: [18033 PDT+ dependent] → [PDT+] 18033 pdt+ dependent
Blocks: 18951
Whiteboard: [PDT+] 18033 pdt+ dependent → [PDT+] [dependent on 18033 getting resolved, which depends on 13378]
Whiteboard: [PDT+] [dependent on 18033 getting resolved, which depends on 13378] → [PDT+] [need input from saari]
I have an idl implementation of this file, attaching patches
Attached patch Makefile patchSplinter Review
Attached file new idl file
Depends on: 19981
Whiteboard: [PDT+] [need input from saari] → [PDT+] [dependent on bug 19981]
talked with Trudelle to see if saari could set 19981 as a top priority, Trudelle
will talk with saari and see what it will entail to resolve 19981, and they will
assign a fix by date. Once the fix by date is set on 19981, then mjudge can set
a fix by date on this bug.
Mike, can you give an estimate of how many days it will take to write the API if
bug 19981 was resolved?
Blocks: 20203
Whiteboard: [PDT+] [dependent on bug 19981] → [PDT+] [19981 fix by date + 3 days]
No longer depends on: 19981
Depends on: 20225
Whiteboard: [PDT+] [19981 fix by date + 3 days] → [PDT+] [20225 fix by date + 3 days]
Mike split 19981 into 2 separate bugs, this is now dependent on 20225 being
resolved, updating summary
I have sford's IDL file working in my tree (I also fixed the spelling to
nsISelectionController since this seemed like the perfect time to do that) and
am awaiting code review by mjudge for that.  Once that's in, I can proceed on

The implementations (and therefore the testing of 18033) are still waiting on
Whiteboard: [PDT+] [20225 fix by date + 3 days] → [PDT+] [by 12/10]
Blocks: 20870
Whiteboard: [PDT+] [by 12/10] → [PDT+] [by 12/15]
updating fix by date
Blocks: 21564
Closed: 20 years ago
Resolution: --- → FIXED
resolved enough for m12.  will add more interfaces as we need them for m13. iam
resolving this one
This can't be verified by QA, of course.

mjudge, please feel free to rubber-stamp this one as verified yourself, or
designate a peer to do a code-level verification. Thanks!
I'll verify it -- I was the one who was waiting for it, and it's working (well,
most of it) now.
Blocks: 22176
No longer blocks: 18471
No longer blocks: 18951
No longer blocks: 20203
No longer blocks: 20870
No longer blocks: 21564
No longer blocks: 22176
You need to log in before you can comment on or make changes to this bug.