180460 - request.cgi doesn't filter list of products/components

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P2)

Description

[Bradley Baetz (:bbaetz)]

The product list (and the subsequent components) aren't being filtered based on
buggroups.

We probably want a GetEnterableProducts thing which ignores the versioncache and
does a single db query instead - it'd be faster than iterating though the
versioncache list + a db query for each.

request.cgi has the extra 

It may be easier to wait for joel's group stuff to land for this, though, or
create the sub as part of that, and then fix requests.cgi here, or something
along those lines.

Comment 1

[Joel Peshkin]

OK, fair enough.

I'll include the GetEnterableProducts() in bug 147275 and we'll get this resolved.

Comment 2

[Bradley Baetz (:bbaetz)]

hmm. The (truncated) third paragraph was meant to talk about the extra
components fun; we may want to the grab code from query.cgi, or just do:

SELECT DISTINCT name FROM components WHERE product_id IN (whatever)

(possibly with ORDER BY) which may be more efficient anyway

Comment 3

[Joel Peshkin]

Attachment: patch

This actually rolls most of what normally would have come from versioncache
into a new query in globals.pl

In the future, this query could be extended to replace versioncache altogether.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 107300 [details] [diff] [review]
patch

>Index: globals.pl


>+sub GetEnterableProductHash {
>+    my $query = "SELECT products.name, components.name, versions.value " .
>+                "FROM products " .
>+                "LEFT JOIN components " .
>+                "ON components.product_id = products.id " .
>+                "LEFT JOIN versions " .
>+                "ON versions.product_id = products.id " .
>+                "LEFT JOIN group_control_map " .
>+                "ON group_control_map.product_id = products.id " .
>+                "AND group_control_map.entry != 0 ";
>+    if ((defined @{$::vars->{user}{groupids}}) 
>+        && (@{$::vars->{user}{groupids}} > 0)) {
>+        $query .= "AND group_id NOT IN(" . 
>+                   join(',',@{$::vars->{user}{groupids}}) . ") ";
>+    }
>+    $query .= "WHERE group_id IS NULL " .
>+              "ORDER BY products.name, components.name, versions.value";

Can't you GROUP BY products.name, components.name, versions.value, and that way
avoid the grep below (which you need in case the product has multiple entry
groups)

Comment 5

[Joel Peshkin]

Attachment: patch v2

Removed versions table info since User.pm and Bug.pm will use a better approach
to making versiontable go away.

Comment 6

[Bradley Baetz (:bbaetz)]

Comment on attachment 107328 [details] [diff] [review]
patch v2

Nedd \Q \E arroudn the grep regexps.

Just use |$_ eq $whatever| = its simpler/easier/etc

Comment 7

[Joel Peshkin]

Attachment: patch v3

OK....	good point. This is much simpler now.

Comment 8

[Joel Peshkin]

Attachment: patch v4

I doubt it will get smaller than this.

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 107331 [details] [diff] [review]
patch v4

r=bbaetz

Comment 10

[Joel Peshkin]

taking assignment and requesting a=

Comment 11

[Joel Peshkin]

checked in

Comment 12

[Dave Miller [:justdave]]

Removing security flag...  this was fixed in 2.17.3, which was out a long time ago.