1804659 - GNOME Shell search provider creates unnecessary windows

Status: RESOLVED FIXED

(Firefox :: Shell Integration, enhancement, P3)

Description

[Anisul Fatma]

Steps to reproduce:

Requirements: a system with the GNOME desktop environment.

1. Open the GNOME Shell Overview.
2. Write some text you wish to look up on a search engine on Firefox, e.g. "How to make brownies?".
3. Along with information from other GNOME Shell search providers, a listing "Search the web for <insert thing you wrote>" appears.
4. Click this listing provided by Firefox's GNOME Shell search provider.

Actual results:

A new Firefox window containing the searched text appears, even if an existing running Firefox instance exists.

Expected results:

If there is an existing running instance of Firefox, a new tab should be opened instead.

Comment 1

[Anisul Fatma]

This issue can be fixed by adding the --new-tab flag in line 357 of browser/components/shell/nsGNOMEShellDBusHelper.cpp. Kudos to Sam Thursfield from GNOME Discourse for actually finding out the file name, line of code, and origin of the bug.

Comment 2

[Simona Badau, Desktop QA]

Setting this to Firefox: Shell Integration, if this is not the right component, please move it to a more appropriate one. Thanks!

Comment 3

[[e-mail] (:bhearsum)]

Thank you so much for the detailed report and suggested fix! I threw together a build with the proposed fix - would you be willing to give it a try and see if it works for you? It's available here: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cK5dMqqqTCu76MNiAm8upQ/runs/0/artifacts/public/build/target.tar.bz2

Comment 4

[[e-mail] (:bhearsum)]

Attachment: Bug 1804659: GNOME Shell search provider creates unnecessary windows r?jhorak!

I was unable to get gnome searching working at all on my machine (perhaps it's broken on Ubuntu?), thus I was unable to verify this fix myself -- but it seems pretty straightforward and safe to take.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e98a929538f
GNOME Shell search provider creates unnecessary windows r=jhorak

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0e98a929538f