1835631 - Gnome shell search is broken

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Gnome shell search is broken due to wrong array size passed to ConstructCommandLine().

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1835631 [Linux] Pass correct array size to ConstructCommandLine() r?emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c49ddd76cee
[Linux] Pass correct array size to ConstructCommandLine() r=emilio

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1804659

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8c49ddd76cee

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9336389 [details]
Bug 1835631 [Linux] Pass correct array size to ConstructCommandLine() r?emilio

Beta/Release Uplift Approval Request

• User impact if declined: Gnome shell search provider is broken.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We pass correct argument num to Firefox command line component so search works as before.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9336389 [details]
Bug 1835631 [Linux] Pass correct array size to ConstructCommandLine() r?emilio

Changing to a release request as we are no linger in beta.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9336389 [details]
Bug 1835631 [Linux] Pass correct array size to ConstructCommandLine() r?emilio

Functional regression, approved as a ride-along for 114 RC 2, thanks.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-release/rev/01bb985167e8