1805233 - Replace created/updated/used times with timeline

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Sergey Galich [:serg]]

Timeline component presents events on the horizontal line. It makes it easier to understand when events happened.
Once we get the change history working, we can add more events to the timeline and make them clickable, so user would be able to select previous point in history (recover from data loss).

Comment 1

[Sergey Galich [:serg]]

Attachment: Bug 1805233 - Replace created/updated/used times with timeline. r=sgalich!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d92870692f2
Replace created/updated/used times with timeline. r=sgalich

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures in browser/components/aboutlogins/tests/chrome/test_login_item.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/2c59a86050aae04d38e301f61b3ac10a35360e30

Push with failures

Failure log

INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/chrome/test_login_item.html | TypeError: can't access property "getAttribute", element is null - Should not throw any errors

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc5baaf503c7
Replace created/updated/used times with timeline. r=sgalich,eemeli

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fc5baaf503c7

Comment 6

[Cosmin Sabou [:CosminS]]

This has been backed out for causing frequent leaks in Bug 1798028. Will be merged to central later on.

Backout link: https://hg.mozilla.org/integration/autoland/rev/92bf950f388660ebc143d4a3308c0cd3f6249eb7

Comment 7

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/92bf950f3886

Comment 8

[Micah [:mtigley] (she/her)]

Hey Cosmin, I was able to replicate the issue with a try push. I made a small change that I'm hoping fixes the issue but it seems like my jobs on TreeHerder with that change are being held up by something. Do you have suggestions on how I can replicate this issue locally? Running all the about:logins tests on a debug build are passing.

Comment 9

[Cosmin Sabou [:CosminS]]

(In reply to Micah [:mtigley] (she/her) from comment #8)

but it seems like my jobs on TreeHerder with that change are being held up by something.

Do you have a link for this try push? We could add jobs there to see if they're passing. Unfortunately I have no answer on how can this be replicated locally.

Comment 10

[Cosmin Sabou [:CosminS]]

Ok, found it, I assume is this one: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&selectedTaskRun=XovC7cG8RtmCNvtS0rgESw.0&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=384caa07410682dd6c8614994f32d05035e99a74

There's a backlog on macOS tasks because of another push, will add jobs on linux and windows to pick those up faster.

LE: looks like it's still leaking here.

Comment 11

[Micah [:mtigley] (she/her)]

I noticed I needed to import the login-timeline module into the tests to be able to access component's shadowRoot. I don't know if that's related at all to the leak since I haven't been able to replicate this locally, but I figured I'd give it another shot: https://treeherder.mozilla.org/jobs?repo=try&revision=4b455bfcae9a6eabc988ff9c08518804cfb5c0d2

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e863493f5734
Replace created/updated/used times with timeline. r=sgalich,eemeli

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e863493f5734

Comment 14

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 111.0a1 (Build ID: 20230122211034) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• "Created", "Last Used" and "Last Modified" section is changed to a timeline and is correctly updated after creating/updating/using a saved login.