Update source-map library
Categories
(DevTools :: Debugger, task)
Tracking
(firefox110 fixed)
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau, NeedInfo)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The currently vendored version of source-map doesn't include the latest wasm binary.
This should bring some nice performance improvement.
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
The main take away are:
- lint fixes
- upgrade of wasm binary built with latest toolchain, bringing perf improvements
This also bundle a script to easily update the vendored files
and update the GITHUB_CHANGESET file accordingly.
|
|
Assignee | |
Comment 2•1 year ago
|
||
I was expecting more improvements, but at least some are reported:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=f6a1fc900225ff611a59f47958d1d79660bbb518&originalSignature=4081483&newSignature=4081483&framework=12&originalRevision=b4e0b31c307268a9edc1489a96a1fb3a33cc886d&page=1&showOnlyConfident=1
15% speedup on source-map.simple.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b09d7f107f31 [devtools] Update source-map libary to latest git changeset. r=bomsy
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
|
||
Comment 5•1 year ago
|
||
Confirming improvements on sourcemap tests:
== Change summary for alert #36493 (as of Tue, 20 Dec 2022 15:32:23 GMT) ==
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 15% | damp source-map.simple.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 226.18 -> 192.31 |
| 8% | damp source-map.allGeneratedPositionsFor.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 185.23 -> 171.15 |
| 7% | damp source-map.originalPositionFor.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender-sw | 264.04 -> 245.54 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36493
|
|
||
Comment 6•1 year ago
|
||
For info, there is a second alert with sourcemap improvements: https://treeherder.mozilla.org/perfherder/alerts?id=36524&hideDwnToInv=0 but the pushlog could either point to this bug or to Bug 1805378
Description
•