Closed Bug 1805289 Opened 2 months ago Closed 1 month ago

Update source-map library

Categories

(DevTools :: Debugger, task)

task

Tracking

(firefox110 fixed)

RESOLVED FIXED
110 Branch
Tracking Status
firefox110 --- fixed

People

(Reporter: ochameau, Assigned: ochameau, NeedInfo)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The currently vendored version of source-map doesn't include the latest wasm binary.
This should bring some nice performance improvement.

https://github.com/mozilla/source-map/pull/465

Assignee: nobody → poirot.alex

The main take away are:

  • lint fixes
  • upgrade of wasm binary built with latest toolchain, bringing perf improvements

This also bundle a script to easily update the vendored files
and update the GITHUB_CHANGESET file accordingly.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b09d7f107f31
[devtools] Update source-map libary to latest git changeset. r=bomsy
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch

Confirming improvements on sourcemap tests:

== Change summary for alert #36493 (as of Tue, 20 Dec 2022 15:32:23 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
15% damp source-map.simple.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 226.18 -> 192.31
8% damp source-map.allGeneratedPositionsFor.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 185.23 -> 171.15
7% damp source-map.originalPositionFor.DAMP linux1804-64-shippable-qr e10s fission stylo webrender-sw 264.04 -> 245.54

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=36493

For info, there is a second alert with sourcemap improvements: https://treeherder.mozilla.org/perfherder/alerts?id=36524&hideDwnToInv=0 but the pushlog could either point to this bug or to Bug 1805378

Flags: needinfo?(poirot.alex)
You need to log in before you can comment on or make changes to this bug.