1805318 - [Cleanup] Update link shown in MobileDownloads component

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

With Bug 1758028 spotlight template is updated to add MobileDownloads component that allows showing QRCode, Link and marketplace icons.

1. Open about:newtab#devtools
2. Search for message PB_FOCUS_PROMO, click show

Expected:
Link shown shouldn't have a grey shadow

Actual:
A grey shadow shows around link

[Nice to have] More recent experiment has shown need to add link CTA and will be good to look into if it can be easily remotely configured to be available for all locales

https://searchfox.org/mozilla-central/rev/2d24d893669ad0fe8d76b0427b25369d35fcc19b/browser/components/newtab/content-src/aboutwelcome/components/MobileDownloads.jsx#36

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Focus promo spotlight modal

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Grey shadow on link

Comment 3

[Hanna Alemu [:hanna_a]]

@pdahiya what are the repro steps for the import screen? Are there other links that have this behavior?

Comment 4

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1805318 - [Cleanup] Update link shown in MobileDownloads component

Comment 5

[Punam Dahiya [:pdahiya]]

(In reply to hanna A from comment #3)

@pdahiya what are the repro steps for the import screen? Are there other links that have this behavior?

Here are steps to see link on Import screen

1. Open about:newtab#devtools
2. Search for message FX_MR_106_UPGRADE
3. On import screen add 'email_link' and 'tiles' property at same level as 'title'
   https://gist.github.com/punamdahiya/df747011ca581a957453cc7eaac68b7e
4. Click Modify and navigate to import screen

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32a27bcc7e0a
[Cleanup] Update link shown in MobileDownloads component r=omc-reviewers,jprickett

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 32a27bcc7e0a (Bug 1805318) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=HvUt8AkUQ0WAHE6f3raHoQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=32a27bcc7e0ad54356ae42732e2ef1300c531606

Log: https://treeherder.mozilla.org/logviewer?job_id=401185979&repo=autoland&lineNumber=4111

Backout: https://hg.mozilla.org/integration/autoland/rev/5b7326a08c05d075c94025363dc83c5d47218a4a

Comment 8

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1805318 - [Cleanup] Update link shown in MobileDownloads component r=jprickett

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13f6360cd892
[Cleanup] Update link shown in MobileDownloads component r=omc-reviewers,jprickett

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/13f6360cd892

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 111.0a1 (Build ID: 20230130214413) and Firefox Beta 110.0b7 (Build ID: 20230129190147) on Windows 10 x64, macOS 11.7.1, and Ubuntu 22.04 x64.

• After following the steps from this Test Plan, I can confirm that the “Email yourself a link” button from the “PB_FOCUS_PROMO” message and the “Import data from Firefox“ button from the “FX_MR_106_UPGRADE” message don’t have a grey background.