1758028 - Implement PBM modal content as per finalized design

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to update Spotlight modal to add configurable fields needed to show PBM modal content as per finalized design for Fx100

https://www.figma.com/file/DuYnaE2DxETEbBFUOrNzyM/Privacy-Segmentation?node-id=707%3A2753

Comment 1

[Meg Viar [:mviar]]

Attachment: Bug 1758028 - Implement PBM modal content as per finalized design r=Mardak,pdahiya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6577528fc15
Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod

Comment 3

[Sandor Molnar[:smolnar]]

Backed out changeset f6577528fc15 (bug 1758028) for causing xpc failures in xpcshell/test_BrowserUtils.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/335b19c65e6defa67b43de03af7e4cded2e58040

Push with failures:

Failure log

INFO -  TEST-PASS | toolkit/modules/tests/xpcshell/test_BrowserUtils.js | test_shouldShowRallyPromo - [test_shouldShowRallyPromo : 124] true == true
[task 2022-03-22T19:49:11.936Z] 19:49:11     INFO -  (xpcshell/head.js) | test run_next_test 1 finished (2)
[task 2022-03-22T19:49:11.936Z] 19:49:11     INFO -  (xpcshell/head.js) | test run_next_test 2 pending (2)
[task 2022-03-22T19:49:11.936Z] 19:49:11     INFO -  (xpcshell/head.js) | test test_shouldShowRallyPromo finished (2)
[task 2022-03-22T19:49:11.937Z] 19:49:11     INFO -  toolkit/modules/tests/xpcshell/test_BrowserUtils.js | Starting test_sendToDeviceEmailsSupported
[task 2022-03-22T19:49:11.937Z] 19:49:11     INFO -  (xpcshell/head.js) | test test_sendToDeviceEmailsSupported pending (2)
[task 2022-03-22T19:49:11.937Z] 19:49:11  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/modules/tests/xpcshell/test_BrowserUtils.js | test_sendToDeviceEmailsSupported - [test_sendToDeviceEmailsSupported : 133] false == true
[task 2022-03-22T19:49:11.937Z] 19:49:11     INFO -  test_BrowserUtils.js:test_sendToDeviceEmailsSupported:133
[task 2022-03-22T19:49:11.937Z] 19:49:11     INFO -  /data/local/tmp/test_root/xpc/head.js:_run_next_test/<:1772
[task 2022-03-22T19:49:11.937Z] 19:49:11     INFO -  /data/local/tmp/test_root/xpc/head.js:_run_next_test:1772
[task 2022-03-22T19:49:11.938Z] 19:49:11     INFO -  /data/local/tmp/test_root/xpc/head.js:run:818
[task 2022-03-22T19:49:11.938Z] 19:49:11     INFO -  /data/local/tmp/test_root/xpc/head.js:_do_main:240
[task 2022-03-22T19:49:11.938Z] 19:49:11     INFO -  /data/local/tmp/test_root/xpc/head.js:_execute_test:603
[task 2022-03-22T19:49:11.938Z] 19:49:11     INFO -  -e:null:1

Comment 4

[Meg Viar [:mviar]]

Looks like preferences are not available in Android, so a default value was needed for browser.send_to_device_locales in BrowserUtils.jsm.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/608d8b8f93a4
Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/608d8b8f93a4

Comment 7

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 100.0a1 (Build ID: 20220323214810) on Windows 10 x64, macOS 11.6, and Ubuntu 20.04.

• The spotlight modal contains the following elements:
  • Firefox Focus logo;
  • “Get Firefox Focus” title;
  • “Scan the QR Code to Download” subtitle;
  • QR code in black and wihite colors;
  • “GET IT ON Google Play” marketplace button;
  • “Download on the Apple Store” marketplace button;
  • “Close” button.

However, while verifying this enhancement, I’ve noticed that the redirected links from the marketplace buttons are reversed:

• The “GET IT ON Google Play” button redirects to the “https://apps.apple.com/us/app/firefox-focus-privacy-browser/id1055677337” page and the “Download it on Apple Store” button redirects to the “https://play.google.com/store/apps/details?id=org.mozilla.focus&referrer=adjust_reftag%3DcIuUhEpaY0dap%26utm_source%3Dproduct-owned%26utm_campaign%3Dfirefox-desktop%26utm_content%3Dpb%26utm_term%3Dfocus-omc172%26utm_medium%3Dreferral” page.
  I logged a different issue for this new behavior (Bug 1761254) and I’m marking this issue as Verified Fixed.