1805338 - Characters in calendar events are garbled after Thunderbird notified

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Takanori MATSUURA]

Step to reproduce:

1. Create events which includes Japanese character with alarms set.
   eg.: Title: テストイベント, Location: 公園, Description: お茶を飲む, Reminder: 5 minutes before
2. Synchronize Google Calendar events with Thunderbird.
3. Notifications are triggered in Thunderbird.
4. Close notifications.

Expected result:
Characters in calendar events are NOT garbled.

Actual result:
Characters in calendar events are garbled and events on Google calendar are updated with garbled character.

Comment 1

[Magnus Melin [:mkmelin]]

Is this on beta/trunk? Perhaps duplicate of bug 1805841?

Comment 2

[Takanori MATSUURA]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Is this on beta/trunk? Perhaps duplicate of bug 1805841?

This happens on Trunk.
The timing of when the bug occurred may correspond to the fix for bug 1762335.
I am not sure, but I think it could be the same problem.

Comment 3

[Takanori MATSUURA]

I suggest this bug should be set to P1 S2 if comm-central use Priority/Severity flags in BMO because this bug breaks major functionality of calendar.
All users which use characters other than US-ASCII in calendar (including emoji) are faced this bug.

Comment 4

[Takanori MATSUURA]

Regression range using mozregression:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=bd859adc317655c724d302ff780125d955e51c08&tochange=5a9e1108b51af7d242104cea842091120b049ccc

Possibly bug 1762335.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1805338 - Fix encoding of vCards and events before network transmission. r=mkmelin

I used the wrong function. Fortunately, the right function exists.

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9308642 [details]
Bug 1805338 - Fix encoding of vCards and events before network transmission. r=mkmelin

[Approval Request Comment]
Requesting early to make sure it happens in the next beta as this is fairly serious.

Regression caused by (bug #): bug 1762335
User impact if declined: events and contacts sent to servers can be garbled
Testing completed (on c-c, etc.): not landed yet but I've checked it manually
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/356bbfab7592
Fix encoding of vCards and events before network transmission. r=mkmelin

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9308642 [details]
Bug 1805338 - Fix encoding of vCards and events before network transmission. r=mkmelin

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 109.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b689aa1be147