1805410 - Ship v113.0.0 of the WebCompat System Addon

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, task)

Description

[Dennis Schubert [:denschub]]

Ship version 113! Soft freeze is happening on 2023-04-06.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: GitHub Pull Request - upstream

Comment 2

[Dennis Schubert [:denschub]]

Attachment: Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. r?twisniewski!

Comment 3

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. (#1629)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a04be53271a7
Ship v113.0.0 of the WebCompat System Addon. r=twisniewski,webcompat-reviewers

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a04be53271a7

Comment 6

[Dennis Schubert [:denschub]]

Comment on attachment 9328224 [details]
Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. r?twisniewski!

Beta/Release Uplift Approval Request

• User impact if declined: A significant amount of user-visible Web Compatibility workarounds would arrive a release cycle late.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have lots of experience shipping WebCompat interventions, and they generally don't break. Even if they break, the worst case is that a already-broken site will stay broken.
• String changes made/needed:
• Is Android affected?: Yes

Comment 7

[Dennis Schubert [:denschub]]

Is Android affected?: Yes

Note that an Android uplift would be nice, but is not required. I don't know how much more effort an Android uplift is. If it's too much work, I'm happy to just skip this. That being said, the linked android-components PR should also apply cleanly as well, as there haven't been any other changes to that code between the last release and my patch.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

We should uplift this to Android as well IMO. To do so, add a comment to the original PR that says @Mergifyio backport releases_v113. That will tell Mergify to create a new uplift PR which should get automatically attached to this bug after creation. You can then add the Beta approval request to that backport PR like normal.

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. (backport #1629) (#1683)

Comment 10

[Dennis Schubert [:denschub]]

Comment on attachment 9329007 [details] [review]
[mozilla-mobile/firefox-android] Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. (backport #1629) (#1683)

Beta/Release Uplift Approval Request

• User impact if declined: A significant amount of user-visible Web Compatibility workarounds would arrive a release cycle late.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We have lots of experience shipping WebCompat interventions, and they generally don't break. Even if they break, the worst case is that a already-broken site will stay broken.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[Dennis Schubert [:denschub]]

Thanks, Ryan! TIL how to do that for Android. :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9328224 [details]
Bug 1805410 - Ship v113.0.0 of the WebCompat System Addon. r?twisniewski!

Approved for 113.0b5.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fb7003875ba9
https://github.com/mozilla-mobile/firefox-android/commit/e6d121cbfb4bcad9bfe4454e26e55aec9e583f4b