1805619 - perma comm/mail/components/enterprisepolicies/tests/browser/browser_policy_disable_safemode.js | application crashed [@ MOZ_Crash(char const*, int, char const*)]

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] thunderbird.net
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=399595247&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/YjvD4LspRzSn6vjVsKS0MQ/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Perma fail. Must be something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7c1415829dcee8814c161503d0f32a438fed118a

Comment 2

[Martin Giger [:freaktechnik]]

Mozilla crash reason: Missing chrome or resource URLs: resource:///modules/MigrationUtils.sys.mjs

Which makes me think it's https://hg.mozilla.org/mozilla-central/rev/912f29a6243b2bf5199462a6ecaf499aeacb9789#l12.13 (bug 718280)
Sadly MigrationUtils.sys.mjs lives in browser and is referenced in toolkit. Maybe the fix here is to update our migration implementation to also provide a local MigrationUtils.sys.mjs?

Also I think bug 1805620 is the same crash.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

I suspect it's this part: https://hg.mozilla.org/mozilla-central/diff/912f29a6243b2bf5199462a6ecaf499aeacb9789/toolkit/modules/ResetProfile.sys.mjs

The test that's failing is loading about:support, which loads ResetProfile.sys.mjs to see if a FirefoxProfileMigrator exists, which is a pre-requisite to doing a profile reset.

Before, it used to check for the existence of the profile by asking XPCOM to see if the migrator was registered as a component. Now that MigrationUtils is doing all of that management, we now ask it instead. And this module is only registered for browser, so crash.

So a few options to fix this:

1. comm stubs out a fake MigrationUtils and returns false for migratorExists. This seems like a kludge and probably an option of last resort.
2. ResetProfile.sys.mjs is modified so that it doesn't assume MigrationUtils exists. It'll check for existence as a first step, and then check that an appropriate migrator exists.

I suggest (2) is probably the best way forward.

Comment 4

[Martin Giger [:freaktechnik]]

Thank you for jumping in here!

I'm not familiar with our migration code nor the toolkit migration paths at all, but I wanted to note that we appear to have our own implementations of the migrator that was previously called, or at least I think we did? https://searchfox.org/comm-central/source/mail/components/migration/src/components.conf

Though I'm not sure we'd ever see any of those "types" from this specific code path.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

From a quick glance, that should still probably work - the mail migrator code still tries to pull its migrators from XPCOM, and that's what it's using to register them, so you should be good there.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1805619 - Check for MigrationUtils before calling into it in ResetProfile.sys.mjs. r?NeilDeakin!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Can you check to see if the patch here fixes the crash for TB?

Comment 8

[Martin Giger [:freaktechnik]]

since this is a testing specific crash code path a comm-try build: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=5d893ff3fb8a5d3216c0a635a30c6ed3cf3bb3d9

Comment 9

[Martin Giger [:freaktechnik]]

Still crashes: https://treeherder.mozilla.org/logviewer?job_id=399653134&repo=try-comm-central&lineNumber=2736

I think the issue is that even trying to resolve the URI triggers the crash: https://searchfox.org/mozilla-central/rev/17aeb39742eba71e0936ae44a51a54197100166d/netwerk/base/nsNetUtil.cpp#3898

So I guess the solution is to check against the app constant?

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Alright, added a condition for MOZ_BUILD_APP to the lazy getter. Does that fix it?

Comment 11

[Martin Giger [:freaktechnik]]

Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2bbdb2266e69218ac6076b811ad139b0bd126965

Comment 12

[Martin Giger [:freaktechnik]]

(In reply to Martin Giger [:freaktechnik] from comment #11)

Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=2bbdb2266e69218ac6076b811ad139b0bd126965

This run looks clean.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/347b3b17f31d
Check for MigrationUtils before calling into it in ResetProfile.sys.mjs. r=NeilDeakin

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/347b3b17f31d

Comment 16

[Intermittent Failures Robot]

26 failures in 3558 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 26

Platform and build breakdown:

• linux1804-64-qr: 6
  • opt: 5
  • debug: 1
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-32-2004-qr: 4
  • opt: 2
  • debug: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-2004-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1805619&startday=2022-12-12&endday=2022-12-18&tree=all