1805819 - Intermittent SUMMARY: ThreadSanitizer: data race /tmp/glibc/time/tzset.c:402 in tzset_internal

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=399698714&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cuBq0UKPTeeZFBm0iHyljQ/runs/0/artifacts/public/logs/live_backing.log

---

I've been looking at enabling GTests on TSAN and this failure is showing up semi-frequently.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Andre, any thoughts on what might be going on here?

Comment 2

[André Bargull [:anba]]

ICU calls tzset on the main-thread here, while on another thread glean calls localtime_r through the chrono rust crate.

tzset and localtime_r are both specified as "MT-Safe", so this should be handled through a TSan suppression. Chromium also handles this through a TSan suppression: bug 1695887, comment #2

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Thanks!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1805819 - Add TSAN suppression for tzset_internal.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b791e55c8a4d
Add TSAN suppression for tzset_internal. r=decoder

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b791e55c8a4d

Comment 7

[Intermittent Failures Robot]

4 failures in 3558 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 4

Platform and build breakdown:

• linux1804-64-tsan-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1805819&startday=2022-12-12&endday=2022-12-18&tree=all