1805860 - Expose storage-access permissions through the Permissions API

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, enhancement)

Description

[Johann Hofmann [:johannh]]

https://github.com/privacycg/storage-access/pull/138 makes it so that SAA is "officially" based on Permissions in the spec, although storage access has always been stored in the permission manager in Firefox internally.

As part of this spec change Chrome would like to expose these permissions through the Permissions API as well, for developer utility. See https://bugs.chromium.org/p/chromium/issues/detail?id=1401266

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1805860 - Remove navigator.permissions.revoke dead code - r=#anti-tracking-reviewers!

Comment 2

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1805860 - Notify PermissionObserver when doubly keyed permissions are updated - r=#anti-tracking-reviewers!

Depends on D182242

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1805860 - Add IPC to test for storage access permission - r=#anti-tracking-reviewers!

Depends on D182243

Comment 4

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1805860 - Extend dom::PermissionStatus to support storage-access permission - r=#anti-tracking-reviewers!

This means:

• Making creation function calls async
• Making GetPrincipal more specific
• Making PermissionState mState protected instead of private and virtualizing UpdateState so children can have custom update logic

Depends on D182244

Comment 5

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1805860 - Add "storage-access" permission to dom::Permissions - r=#anti-tracking-reviewers!

Depends on D182245

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8693b9449d3
Remove navigator.permissions.revoke dead code - r=anti-tracking-reviewers,ipc-reviewers,webidl,saschanaz,mccr8,timhuang
https://hg.mozilla.org/integration/autoland/rev/48558ba49efe
Notify PermissionObserver when doubly keyed permissions are updated - r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/d2a6174bbb14
Add IPC to test for storage access permission - r=anti-tracking-reviewers,timhuang,pbz
https://hg.mozilla.org/integration/autoland/rev/3acd0ba1dba6
Extend dom::PermissionStatus to support storage-access permission - r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/d48d415fca83
Add "storage-access" permission to dom::Permissions - r=anti-tracking-reviewers,webidl,saschanaz,pbz,smaug

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing bp-nu bustages in StorageAccessAPIHelper.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/toolkit/components/antitracking/StorageAccessAPIHelper.cpp:873:5: error: unknown type name 'FeaturePolicy'; did you mean 'dom::FeaturePolicy'?

Comment 8

[Benjamin VanderSloot [:bvandersloot]]

This is a simple fix in the compile that I will get right on.

This built successfully locally and in a try run on linux64. How can I catch errors like this before landing?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfa22051eca
Remove navigator.permissions.revoke dead code - r=anti-tracking-reviewers,ipc-reviewers,webidl,saschanaz,mccr8,timhuang
https://hg.mozilla.org/integration/autoland/rev/e8b855af9e2b
Notify PermissionObserver when doubly keyed permissions are updated - r=anti-tracking-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/8ed902714cda
Add IPC to test for storage access permission - r=anti-tracking-reviewers,timhuang,pbz
https://hg.mozilla.org/integration/autoland/rev/f729d92211b1
Extend dom::PermissionStatus to support storage-access permission - r=anti-tracking-reviewers,pbz
https://hg.mozilla.org/integration/autoland/rev/b681bc2053b3
Add "storage-access" permission to dom::Permissions - r=anti-tracking-reviewers,webidl,saschanaz,pbz,smaug

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6bfa22051eca
https://hg.mozilla.org/mozilla-central/rev/e8b855af9e2b
https://hg.mozilla.org/mozilla-central/rev/8ed902714cda
https://hg.mozilla.org/mozilla-central/rev/f729d92211b1
https://hg.mozilla.org/mozilla-central/rev/b681bc2053b3