1805878 - When opening .eml: No-reply "Reply not supported" popup shouldn't appear if there is a valid Reply-To:

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Costel]

Attachment: noreply-bug.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

Steps to reproduce:

Reply to a message coming from a noreply@ address, but that has a valid Reply-To header

Actual results:

The "Reply not supported" popup appears warning about the FROM noreply@

Expected results:

Popup shouldn't have appeared since the compose window will open with the REPLY-TO address, which is a valid one (not a noreply@ one)

Comment 1

[Thomas D. (:thomas8)]

Hey Costel, I've tried this on Win11, TB 102.5.1, and it works for me exactly as it should.

• Message has From: no-reply@...
• If there's a normal reply-to address (which doesn't have noreply itself), no alert
• If there's no reply-to address, alert seen
• I even tested exactly your addresses and still wfm

Can you attach a testcase.eml message (replace privacy matter please) via Attach New File above?

Comment 2

[Costel]

Win 10, TB 102.6.0 here, attached a test case.

Comment 3

[Costel]

Attachment: testcase.eml

Comment 4

[Thomas D. (:thomas8)]

Comment on attachment 9308554 [details]
testcase.eml

For easy viewing, let's use text/plain.

Comment 5

[Thomas D. (:thomas8)]

(In reply to Costel from comment #2)

Win 10, TB 102.6.0 here, attached a test case.

Thanks for rapid reply! Have tested your testcase, and still not getting the no-reply prompt.
Wfm on TB 102.6.0 on Win11, Win10.

• Is contact@gdpr... the email address of one of your identities?
• Does replying to your testcase show the no-reply prompt every time?
• How exactly do you reply and where is the message? (IMAP custom folder in my case)
• Does no-reply prompt occur with Help > Troubleshoot mode?
• Which address is in To field when you choose Reply Anyway?

Kindly use reply button above this comment for inline replies.
Without further information which allows us to reproduce, unfortunately there's nothing we can do here...

Comment 6

[Thomas D. (:thomas8)]

needinfo from reporter for my questions in comment 5...

Comment 7

[Costel]

• contact@gdpr is not an email installed in my TB (if that's what you asked)
• Yes, the prompt appears every time
• The recipient of this test mail is a Yahoo address setup as IMAP; mail sits in the default Inbox folder
• Yes, prompt appears in Troubleshoot mode
• TO = GDPRgenerator <[e-mail]> when I reply

Comment 8

[Magnus Melin [:mkmelin]]

Can't reproduce. Try Help | Troubleshoot mode

Comment 9

[Costel]

As confirmed in my previous comment #7, prompt appears in Troubleshoot mode

Comment 10

[aj]

I have the same issue with TB 115.10.1 on Debian 12 (amd64)

Comment 11

[Alfred Peters [:infofrommozilla]]

(In reply to Costel from comment #7)

• Yes, the prompt appears every time
• The recipient of this test mail is a Yahoo address setup as IMAP; mail sits in the default Inbox folder
• TO = GDPRgenerator <[e-mail]> when I reply

Unfortunately, I cannot reproduce this behavior with the test email in an IMAP folder.

Nevertheless, I can see the bug with the test email when I open it from an external file:
Menu -> File -> Open -> Saved Message...

Comment 12

[Alfred Peters [:infofrommozilla]]

(In reply to Alfred Peters [:infofrommozilla] from comment #11)

Nevertheless, I can see the bug with the test email when I open it from an external file:

https://searchfox.org/comm-central/rev/9719fdb49993b2fcf8eafffd3e6197af7a1aeac9/mail/base/content/mailCommands.js#253

          const replyTo = hdr.getStringProperty("replyTo");

In this case, getStringProperty()returns an empty string instead of the header value. The rest results from this.

Comment 13

[Magnus Melin [:mkmelin]]

To handle replying to .eml
https://searchfox.org/comm-central/rev/6bb2aa8901badea13b71985e04715bdfa35a3875/mailnews/local/src/nsMsgFileHdr.cpp#90,118 - would need to store and use Reply-To for it.

Comment 14

[Matthew Butterworth]

I'd like to take this. I can reproduce it with testcase.eml and the comment above (#13) is a helpful pointer.

Comment 15

[Matthew Butterworth]

Attachment: Bug 1805878 - Return Reply-To from nsMsgFileHdr for opened .eml files. r?mkmelin

nsMsgFileHdr never stored Reply-To, so replying to a message opened from a file fell back to the From address and could show the no-reply prompt even when a valid Reply-To was present.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/01232de50e68
Return Reply-To from nsMsgFileHdr for opened .eml files. r=mkmelin