1806072 - screen.orientation.angle is always 0 on Pixel 6a

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Makoto Kato [:m_kato]]

When I test screen orientation APIs on Pixel 6a, I found that angle is always 0. I guess that is is similar to bug 1754802.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

When using Pixel 6a, orientation information seems to be invalid. It seems that
this is similar to bug 1754802.

So we should get the rotation information from ScreenCompat per API level.

And, when changing screen orientation by screen.orientation.lock(), Display
Manager API observes changing, but it may get previous information at this
timing. After changing display information, onConfigureChanges is notified,
then we an get correct information, so we have to update information via it if
newer Android.

Comment 2

[Chris Peterson [:cpeterson]]

Makoto, do you think we should uplift your fix to Beta 109? Does this bug only affect Pixel 6a devices?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Chris Peterson [:cpeterson] from comment #2)

Makoto, do you think we should uplift your fix to Beta 109? Does this bug only affect Pixel 6a devices?

I cannot reproduce this on emulator image (Android 13), but I can reproduce this on Pixel 4a and Pixel 6a. I guess that some devices on Android 12+ such as bug 1754802's OnePlus device will reproduce this. If not too late, we should uplift this fix to beta.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddf5f22cd611
screen.orientation.angle isn't updated on Pixel 6a. r=geckoview-reviewers,owlish

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ddf5f22cd611

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 9308649 [details]
Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: When using screen orientation API to get current screen angle, Google Pixel 4+ device doesn't get current value.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): When device is Android 12+, we use recommended API instead.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9308649 [details]
Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

Approved for 109.0b7

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/60558319004b

Comment 10

[Atila Butkovits]

Backed out for blocking Android Components from being updated in Fenix nightly.

Backout link: https://hg.mozilla.org/integration/autoland/rev/23f995f7972e3c98a1a7d2426f9052e1692b2e42

Comment 11

[Dianna Smith [:diannaS]]

Backed out changeset 60558319004b out of Beta to avoid test failures in Fenix beta
Backout link: https://hg.mozilla.org/releases/mozilla-beta/rev/d3e8b8bfa752dedc3ba24b0e585b05f07d535501

Comment 12

[Dianna Smith [:diannaS]]

Comment on attachment 9308649 [details]
Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

No longer going out in 109.0b7, please re-nominate if a new patch is needed in beta

Comment 13

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/23f995f7972e3c98a1a7d2426f9052e1692b2e42

Comment 14

[Makoto Kato [:m_kato]]

(In reply to Atila Butkovits from comment #10)

Backed out for blocking Android Components from being updated in Fenix nightly.

Backout link: https://hg.mozilla.org/integration/autoland/rev/23f995f7972e3c98a1a7d2426f9052e1692b2e42

Could you point out failure job link?

Comment 15

[Dianna Smith [:diannaS]]

https://firefox-ci-tc.services.mozilla.com/tasks/dGUusGEGQ8K8Oq0lQZqbZQ/runs/0/logs/public/logs/live.log#L24174

Comment 16

[Intermittent Failures Robot]

1 failures in 1328 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1806072&startday=2022-12-26&endday=2023-01-01&tree=all

Comment 17

[Makoto Kato [:m_kato]]

Fenix's unit test seems to create GeckoScreenOrientation object on non-Android environment. I have to to add check for context.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/041ba3a6ffc5
screen.orientation.angle isn't updated on Pixel 6a. r=geckoview-reviewers,owlish

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/041ba3a6ffc5

Comment 20

[(Out Sep 17-23) Ryan VanderMeulen]

Comment on attachment 9308649 [details]
Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

Patch has successfully made it into Fenix nightly builds now. Re-nominating for Beta consideration.

Comment 21

[(Out Sep 17-23) Ryan VanderMeulen]

Comment on attachment 9308649 [details]
Bug 1806072 - screen.orientation.angle isn't updated on Pixel 6a. r=#geckoview-reviewers

Approved for Fenix/Focus 109.0b5.

Comment 22

[(Out Sep 17-23) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef4acde8bab6