1828611 - Opening PiP window shows browser toolbar and web page instead of just the video.

Status: RESOLVED DUPLICATE of bug 1956165

(Firefox for Android :: Media, defect, P2)

Description

[Kestrel]

Attachment: PiP window displaying toolbar and page title instead of video

STR:

1. Visit dailymotion.com on Nightly 114.0a1, Samsung S20 (Android 13).
2. Select a video and start playing with sound.
3. Rotate phone to landscape (not required but increases reproducibility).
4. Make the video fullscreen (landscape).
5. Press the home button (or swipe home) to open PiP window.
6. Repeat steps 3-5 if necessary.

The browser toolbar appears inside the PiP window after the layout re-organizes and the top of the page may be visible instead of the video. Only happens when fullscreen is in landscape orientation, not in portrait. Does not happen with the desktop site. The position and appearance of the toolbar does not make any difference.

Regression window:
Last good build: 2023-01-03 2015925195
First bad build: 2023-01-03 2015925291
https://github.com/mozilla-mobile/fenix/commits?since=2023-01-03&until=2023-01-03

Possibly regressed by #3722 - Open searchbox when trigerring assistant.

See also #11600 - The url bar appears when using Picture in Picture.

Comment 1

[Kestrel]

:boek, since you are the author of the likely regressor, #28101, could you take a look?

Comment 2

[Jeff Boek [:boek]]

Good find, will definitely take a look.

Comment 3

[eclaudiu64]

Attachment: mobizen_20230427_205131_001.mp4

This problem is also in Firefox Focus. When pip is entered, it disappears immediately after the screen.

Comment 4

[Jeff Boek [:boek]]

I spent some time investigating this and with reverting #3722 - Open searchbox when trigerring assistant. I was still able to reproduce the bug. It looks like we also merged a few updates to android components in that commit range so its likely the regression happened there.

https://github.com/mozilla-mobile/firefox-android/commits?since=2023-01-02&until=2023-01-03

Comment 5

[Jeff Boek [:boek]]

:kaya dug into GV changes in that timespan and found https://hg.mozilla.org/mozilla-central/rev/041ba3a6ffc5f955e2c792ac80e8f95a85244810. Backing this out they were no longer able to reproduce the bug. Will continue to investigate.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1806072

Comment 7

[Jeff Boek [:boek]]

Hey Makoto,

Do you have any ideas on why this change could cause this issue?

Comment 8

[Makoto Kato [:m_kato]]

I am investigating why.

Comment 9

[Makoto Kato [:m_kato]]

(I guess that View.onConfigurationChanged still return previous data...., so when removing runtime.orientationChanged call, this can fix it. But I don't test it yet)

Comment 10

[Makoto Kato [:m_kato]]

Could you reproduce this on other Samsung device such as Google Pixel?

Comment 11

[Kestrel]

I can reproduce it on LineageOS and LG devices in addition to Samsung.

Comment 12

[Makoto Kato [:m_kato]]

This issue isn't regression by bug 1806072. After backed out bug 1806072, I can reproduce this on Android 12.

I think that this issue is AC side. When entering PiP, content script (of dailymotion) seems to calls document.exitFullscreen. Then MediaSessionDelegate calls onFullscreen to notify exiting fullscreen correctly.

I guess that this may be a timing issue of entering PiP and exit fullscreen delegation.

Comment 13

[Makoto Kato [:m_kato]]

By bug 1806072, screen orientation change event is fired correctly, and screen angle returns correct value. I guess that content script of dailymotion handles this event and/or value, then call document.exitFullscreen. This issue depends on dailymotion's script.

Comment 14

[eclaudiu64]

I notice that this problem with Picture-in-Pictute - PIP, is also reproduced on other websites. It's not just on Dailymotion.

Comment 15

[Kestrel]

Can you give an example site? I have only seen it on dailymotion.

Comment 16

[eclaudiu64]

(In reply to Kestrel from comment #15)

Can you give an example site? I have only seen it on dailymotion.

On the following sites: https://edition.cnn.com and on an adult site: pornhub.com
On these 2 sites I noticed this problem with the videos.

Comment 17

[Kestrel]

Thanks, I can reproduce it on those two sites as well. I needed to use https://edition.cnn.com/videos to get videos to open in proper fullscreen.

Comment 18

[eclaudiu64]

Attachment: mobizen_20230603_145828.mp4

I also noticed this problem on the desktop version of YouTube. PIP does not display the video and there is another issue with the video displaying correctly in landscape mode on desktop which is on this ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1809251

Comment 19

[eclaudiu64]

Will this error be solved with PIP?

Comment 20

[eclaudiu64]

Is there an update to this error?

Comment 22

[Jeff Boek [:boek]]

Going to try to pull this in next sprint

Comment 24

[Mira Lobontiu (Android QA)]

Attachment: logcat.txt

I was able to reproduce this issue on the 131.0a1 Fenix Nightly from 8/6 with a Xiaomi Mi8 Lite (Android 10) device, on a youtube video.
I've attached a logcat, maybe it helps debugging this.

NOT reproducible on Beta 130.0b2.

Comment 25

[Mira Lobontiu (Android QA)]

Attachment: Screenshot_2024-08-08-14-44-59-060_com.miui.home.jpg

Comment 26

[Kestrel]

(In reply to miralobontiu from comment #24)

NOT reproducible on Beta 130.0b2.

I can still reproduce the issue with dailymotion on Beta 130.0b3. Try doing a clean install of Beta.

Comment 27

[Titouan Thibaud [:titouan]]

Is this bug still reproducible in Nightly?

Comment 28

[Kestrel]

Yes, it still happens with latest Nightly 136.0a1.

Comment 30

[Kestrel]

I can still reproduce this with latest Nightly 140.0a1 so not a duplicate of Bug 1956165.

Comment 31

[Iorga Gabriel]

Attachment: screen-20250603-134317 (1).mp4

Comment 32

[Iorga Gabriel]

Please see video screen-20250603-134317 (1).mp4
STR:

1. Visit dailymotion.com on Pixel 7 (Android 16).
2. Rotate phone to landscape.
3. Make the video fullscreen (landscape).
4. Press the home button (or swipe home) to open PiP window.

On YouTube, with the same steps, it is working.

On Dailymotion, if the site doesn't rotate the video automatically in landscape mode when it is full screen, it is working as it should.

GeckoEngineSession: 
 override fun onFullScreen(session: GeckoSession, fullScreen: Boolean) {
            notifyObservers { onFullScreenChange(fullScreen) }
        }

Returns false when the bug is happening. When you press home button.

Comment 33

[Titouan Thibaud [:titouan]]

Here is a profile I took while reproducing the bug: https://share.firefox.dev/4mJQG1H

Comment 34

[Cathy Lu [:calu]]

Additional devices that encounter this bug:

Firefox version: Nightly 140.0a1 from 5/7, Beta 139.0b4, and Firefox for android 138.0.2
Android devices: Samsung Galaxy A14 (Android 14), Oppo Find X3 Lite (Android 11), Oppo Find X3 Neo (Android 11)

From Bug 1964984